8000 ROCM: Remove det_singular OpInfo · arindamroy-eng/pytorch-1@c383b2c · GitHub
[go: up one dir, main page]

Skip to content

Commit c383b2c

Browse files
arindamroy-engpytorchmergebot
authored andcommitted
ROCM: Remove det_singular OpInfo
According to comments in pytorch#93045 (comment) The test has been flaky all over. Hence submitting this PR to remove the test itself. Resolves (pytorch#93045). Signed-off-by: Arindam Roy <rarindam@gmail.com>
1 parent f22d99c commit c383b2c

File tree

1 file changed

+0
-81
lines changed
  • torch/testing/_internal/opinfo/definitions

1 file changed

+0
-81
lines changed

torch/testing/_internal/opinfo/definitions/linalg.py

Lines changed: 0 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -1198,87 +1198,6 @@ def make_input():
11981198
decorators=[skipCPUIfNoLapack, skipCUDAIfNoMagmaAndNoCusolver],
11991199
check_batched_gradgrad=False,
12001200
),
1201-
OpInfo(
1202-
"linalg.det",
1203-
aten_name="linalg_det",
1204-
op=torch.linalg.det,
1205-
variant_test_name="singular",
1206-
aliases=("det",),
1207-
dtypes=floating_and_complex_types(),
1208-
supports_forward_ad=True,
1209-
supports_fwgrad_bwgrad=True,
1210-
check_batched_gradgrad=False,
1211-
sample_inputs_func=sample_inputs_linalg_det_singular,
1212-
decorators=[skipCPUIfNoLapack, skipCUDAIfNoMagmaAndNoCusolver],
1213-
skips=(
1214-
DecorateInfo(
1215-
unittest.skip("The backward may give different results"),
1216-
"TestCommon",
1217-
"test_noncontiguous_samples",
1218-
),
1219-
DecorateInfo(
1220-
unittest.skip("Gradients are incorrect on macos"),
1221-
"TestBwdGradients",
1222-
"test_fn_grad",
1223-
device_type="cpu",
1224-
dtypes=(torch.float64,),
1225-
active_if=IS_MACOS,
1226-
),
1227-
DecorateInfo(
1228-
unittest.skip("Gradients are incorrect on macos"),
1229-
"TestFwdGradients",
1230-
"test_forward_mode_AD",
1231-
device_type="cpu",
1232-
dtypes=(torch.float64,),
1233-
active_if=IS_MACOS,
1234-
),
1235-
# Both Hessians are incorrect on complex inputs??
1236-
DecorateInfo(
1237-
unittest.expectedFailure,
1238-
"TestBwdGradients",
1239-
"test_fn_gradgrad",
1240-
dtypes=(torch.complex128,),
1241-
),
1242-
DecorateInfo(
1243-
unittest.expectedFailure,
1244-
"TestFwdGradients",
1245-
"test_fn_fwgrad_bwgrad",
1246-
dtypes=(torch.complex128,),
1247-
),
1248-
DecorateInfo(
1249-
unittest.skip("Skipped, see https://github.com//issues/84192"),
1250-
"TestBwdGradients",
1251-
"test_fn_gradgrad",
1252-
device_type="cuda",
1253-
),
1254-
DecorateInfo(
1255-
unittest.skip("Skipped, see https://github.com//issues/84192"),
1256-
"TestFwdGradients",
1257-
"test_fn_fwgrad_bwgrad",
1258-
device_type="cuda",
1259-
),
1260-
DecorateInfo(
1261-
unittest.skip(
1262-
"Flaky on ROCm https://github.com/pytorch/pytorch/issues/93044"
1263-
),
1264-
"TestBwdGradients",
1265-
"test_fn_grad",
1266-
device_type="cuda",
1267-
dtypes=get_all_complex_dtypes(),
1268-
active_if=TEST_WITH_ROCM,
1269-
),
1270-
DecorateInfo(
1271-
unittest.skip(
1272-
"Flaky on ROCm https://github.com/pytorch/pytorch/issues/93045"
1273-
),
1274-
"TestFwdGradients",
1275-
"test_forward_mode_AD",
1276-
device_type="cuda",
1277-
dtypes=get_all_complex_dtypes(),
1278-
active_if=TEST_WITH_ROCM,
1279-
),
1280-
),
1281-
),
12821201
OpInfo(
12831202
"linalg.diagonal",
12841203
aten_name="linalg_diagonal",

0 commit comments

Comments
 (0)
0