Fixing the comparison for setting the input current limit to 900 mA. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rob Singleton seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Memory usage change @ cc834bf
Click for full report table
Click for full report CSV |
8000
per1234
requested changes
Aug 2, 2023
There was a problem hiding this comment.
Hi @rsingletonDS. Thanks so much for your pull request!
I see that the @CLAassistant bot has not been able to validate the pull request.
As explained by the bot, this is likely caused by the email address used in your local Git settings not being associated with your GitHub account.
You can see the email address associated with the commit here:
Please follow these instructions to resolve the issue:
Hopefully the check will automatically pass once that has been done. If not, please comment here and we will investigate.
|
As soon as the CLA is singed I'll go on and merge this (or probably @per1234 you can do it too 🙂 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the 900 mA input current limit setting. It doesn't have the double/float comparison fix you asked me to remove.