Revert "Match return value to type in available()"

cmaglie · cmaglie · commit 62cf4b6b55ef · 2014-10-21T17:18:26.000+02:00
This reverts commit f40e471. Added an hint for the buffer sizes. See arduino#2057 Fixes arduino#2367
diff --git a/hardware/arduino/cores/arduino/HardwareSerial.cpp b/hardware/arduino/cores/arduino/HardwareSerial.cpp
@@ -53,6 +53,8 @@
 // using a ring buffer (I think), in which head is the index of the location
 // to which to write the next incoming character and tail is the index of the
 // location from which to read.
+// NOTE: a "power of 2" buffer size is reccomended to dramatically
+//       optimize all the modulo operations for ring buffers.
 #if (RAMEND < 1000)
   #define SERIAL_BUFFER_SIZE 16
 #else
@@ -426,7 +428,7 @@ void HardwareSerial::end()
 
 int HardwareSerial::available(void)
 {
-  return (int)(SERIAL_BUFFER_SIZE + _rx_buffer->head - _rx_buffer->tail) % SERIAL_BUFFER_SIZE;
+  return ((unsigned int)(SERIAL_BUFFER_SIZE + _rx_buffer->head - _rx_buffer->tail)) % SERIAL_BUFFER_SIZE;
 }
 
 int HardwareSerial::peek(void)
