8000 Fix/del leftover symbols - v 1.5.1 by ubidefeo · Pull Request #20 · arduino/micropython.js · GitHub
[go: up one dir, main page]
Skip to content

Fix/del lef 8000 tover symbols - v 1.5.1 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2024
Merged

Fix/del leftover symbols - v 1.5.1 #20

merged 3 commits into from
Dec 10, 2024

Conversation

ubidefeo
Copy link
Collaborator
@ubidefeo ubidefeo commented Dec 9, 2024

This PR takes care of cleaning up some objects created by helper scripts which would otherwise be allocated in the board's RAM when used with Lab for MicroPython.

l, b, f, w are deleted after use

additionally I spotted a bug in cli.js in executeString()

@ubidefeo
Refactored commands. Delete f,w,l leftover symbols.
63a1402 
Signed-off-by: ubi de feo <me@ubidefeo.com>
@ubidefeo
Removed leftover 'file' and renamed variable to 'f'.
2c26a58 
Signed-off-by: ubi de feo <me@ubidefeo.com>
@ubidefeo
Updated package version.
050d300 
Signed-off-by: ubi de feo <me@ubidefeo.com>
@ubidefeo ubidefeo changed the base branch from main to development December 9, 2024 11:29
eigen-value
eigen-value approved these changes Dec 10, 2024
View reviewed changes
Copy link
@eigen-value eigen-value left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (Win11) and approved

@ubidefeo ubidefeo merged commit ea101e5 into development Dec 10, 2024
1 check passed
@ubidefeo ubidefeo deleted the fix/del-leftover-symbols branch December 10, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eigen-value eigen-value eigen-value approved these changes

@murilopolese murilopolese Awaiting requested review from murilopolese

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubidefeo @eigen-value
0