8000 Comments and logging cleanup. · arduino/lab-micropython-editor@03cc893 · GitHub
[go: up one dir, main page]

Skip to content

Commit 03cc893

Browse files
committed
Comments and logging cleanup.
Signed-off-by: ubi de feo <me@ubidefeo.com>
1 parent 380b6bd commit 03cc893

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,11 @@ app.on('ready', () => {
6565
createWindow()
6666

6767
win.on('focus', () => {
68-
console.log("win focus")
68+
// console.log("win focus")
6969
})
7070

7171
win.on('blur', () => {
72-
console.log("win blur")
72+
// console.log("win blur")
7373
})
7474

7575
})

ui/arduino/store.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ async function confirmDialog(msg, cancelMsg, confirmMsg) {
2424
cancelId: 1,
2525
message: msg
2626
})
27-
console.log('confirm', response)
2827
return Promise.resolve(response)
2928
}
3029

@@ -103,8 +102,8 @@ async function store(state, emitter) {
103102
}
104103
emitter.emit('render')
105104
})
105+
106106
emitter.on('change-view', (view) => {
107-
108107
if (state.view === 'file-manager') {
109108
if (view != state.view) {
110109
state.selectedFiles = []
@@ -161,7 +160,7 @@ async function store(state, emitter) {
161160
cancelId: 0,
162161
message: "Could not connect to the board. Reset it and try again."
163162
})
164-
console.log('Reset request acknowledged', response)
163+
// console.log('Reset request acknowledged', response)
165164
emitter.emit('connection-timeout')
166165
}, 3500)
167166
try {
@@ -1197,7 +1196,7 @@ async function store(state, emitter) {
11971196
&& f.source == selectedFile.source
11981197
&& f.parentFolder == selectedFile.parentFolder
11991198
})
1200-
console.log('already open', alreadyOpen)
1199+
// console.log('already open', alreadyOpen)
12011200

12021201
if (!alreadyOpen) {
12031202
// This file is not open yet,
@@ -1547,19 +1546,16 @@ async function store(state, emitter) {
15471546

15481547
function filterDoubleRun(onlySelected = false) {
15491548
if (preventDoubleRun) return
1550-
console.log('>>> RUN CODE ACTUAL <<<')
15511549
emitter.emit('run', onlySelected)
15521550
timedReset()
15531551
}
15541552

15551553
function runCode() {
1556-
console.log('>>> RUN CODE REQUEST <<<')
15571554
if (canExecute({ view: state.view, isConnected: state.isConnected })) {
15581555
filterDoubleRun()
15591556
}
15601557
}
15611558
function runCodeSelection() {
1562-
console.log('>>> RUN CODE REQUEST <<<')
15631559
if (canExecute({ view: state.view, isConnected: state.isConnected })) {
15641560
filterDoubleRun(true)
15651561
}
@@ -1638,7 +1634,6 @@ async function store(state, emitter) {
16381634
// LEAK > listeners keep getting added and not removed when tabs are closed
16391635
// additionally I found that closing a tab has actually added an extra listener
16401636
newFile.editor.onChange = function() {
1641-
console.log('editor has changes')
16421637
newFile.hasChanges = true
16431638
emitter.emit('render')
16441639
}

0 commit comments

Comments
 (0)
0