8000 fix: revive `--theia-icon-loading` in IDE2 · arduino/arduino-ide@bfcb518 · GitHub
[go: up one dir, main page]
Skip to content

Commit bfcb518

Browse files
author
Akos Kitta
committed
fix: revive --theia-icon-loading in IDE2
 - it has been removed from Theia - aligned the DOM structure to previous the version when using widget Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
1 parent f338106 commit bfcb518

File tree

4 files changed

+33
-14
lines changed

4 files changed

+33
-14
lines changed

‎arduino-ide-extension/src/browser/dialogs/firmware-uploader/firmware-uploader-dialog.tsx

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,17 @@ export class UploadFirmwareDialog extends ReactDialog<void> {
6767

6868
protected override render(): React.ReactNode {
6969
return (
70-
<form>
71-
<FirmwareUploaderComponent
72-
availableBoards={< 8000 /span>this.availableBoards}
73-
firmwareUploader={this.arduinoFirmwareUploader}
74-
flashFirmware={this.flashFirmware.bind(this)}
75-
updatableFqbns={this.updatableFqbns}
76-
isOpen={this.isOpen}
77-
/>
78-
</form>
70+
<div>
71+
<form>
72+
<FirmwareUploaderComponent
73+
availableBoards={this.availableBoards}
74+
firmwareUploader={this.arduinoFirmwareUploader}
75+
flashFirmware={this.flashFirmware.bind(this)}
76+
updatableFqbns={this.updatableFqbns}
77+
isOpen={this.isOpen}
78+
/>
79+
</form>
80+
</div>
7981
);
8082
}
8183

@@ -86,11 +88,6 @@ export class UploadFirmwareDialog extends ReactDialog<void> {
8688
this.update();
8789
}
8890

89-
protected override onUpdateRequest(msg: Message): void {
90-
super.onUpdateRequest(msg);
91-
this.update();
92-
}
93-
9491
// eslint-disable-next-line unused-imports/no-unused-vars, @typescript-eslint/no-unused-vars
9592
protected override handleEnter(event: KeyboardEvent): boolean | void {
9693
return false;

‎arduino-ide-extension/src/browser/icons/loading-dark.svg

Lines changed: 6 additions & 0 deletions
< 8000 div class="Box-sc-g0xbh4-0 kAxYNj">
Loading

‎arduino-ide-extension/src/browser/icons/loading-light.svg

Lines changed: 6 additions & 0 deletions
Loading

‎arduino-ide-extension/src/browser/style/index.css

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,16 @@
2020
@import './progress-bar.css';
2121
@import './settings-step-input.css';
2222

23+
/* Revive of the `--theia-icon-loading`. The variable has been removed from Theia while IDE2 still uses is. */
24+
/* The SVG icons are still part of Theia (1.31.1) */
25+
/* https://github.com/arduino/arduino-ide/pull/1662#issuecomment-1324997134 */
26+
body {
27+
--theia-icon-loading: url(../icons/loading-light.svg);
28+
}
29+
body.theia-dark {
30+
--theia-icon-loading: url(../icons/loading-dark.svg);
31+
}
32+
2333
.theia-input.warning:focus {
2434
outline-width: 1px;
2535
outline-style: solid;

0 commit comments

Comments
 (0)
0