Fix serial upload not working with all boards

silvanocerza · silvanocerza · commit 1e66d57b9722 · 2021-10-20T15:05:03.000+02:00
diff --git a/arduino-ide-extension/src/browser/contributions/upload-sketch.ts b/arduino-ide-extension/src/browser/contributions/upload-sketch.ts
@@ -233,7 +233,7 @@ export class UploadSketch extends SketchContribution {
       const { selectedPort } = boardsConfig;
       const port = selectedPort;
       const userFields = this.cachedUserFields.get(this.selectedFqbnAddress());
-      if (!userFields) {
+      if (!userFields && this.boardRequiresUserFields) {
         this.messageService.error(nls.localize('arduino/sketch/userFieldsNotFoundError', "Can't find user fields for connected board"));
         return;
       }

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ export class UploadSketch extends SketchContribution {`
`233`	`233`	`const { selectedPort } = boardsConfig;`
`234`	`234`	`const port = selectedPort;`
`235`	`235`	`const userFields = this.cachedUserFields.get(this.selectedFqbnAddress());`
`236`		`- if (!userFields) {`
	`236`	`+ if (!userFields && this.boardRequiresUserFields) {`
`237`	`237`	`this.messageService.error(nls.localize('arduino/sketch/userFieldsNotFoundError', "Can't find user fields for connected board"));`
`238`	`238`	`return;`
`239`	`239`	`}`