Added gRPC calls. (#1492)

* Added new Monitor command (will replace current Monitor service) * Added new EnumerateMonitorPortParameters gRPC call * Force compile error on gRPC deamon when there are unimplemented methods * Updated deamon implementation stub * fix i18n
arduino · cmaglie · Oct 11, 2021 · Oct 4, 2021 · Oct 4, 2021 · Oct 5, 2021
commit 802917d68e8eb3c2f88aacf1ca382f8bc196f678
diff --git a/commands/daemon/daemon.go b/commands/daemon/daemon.go
@@ -37,7 +37,9 @@ import (
 
 // ArduinoCoreServerImpl FIXMEDOC
 type ArduinoCoreServerImpl struct {
-	rpc.UnimplementedArduinoCoreServiceServer
+	// Force compile error for unimplemented methods
+	rpc.UnsafeArduinoCoreServiceServer
+
 	VersionString string
 }
 
@@ -463,3 +465,13 @@ func (s *ArduinoCoreServerImpl) GitLibraryInstall(req *rpc.GitLibraryInstallRequ
 	}
 	return stream.Send(&rpc.GitLibraryInstallResponse{})
 }
+
+// EnumerateMonitorPortSettings FIXMEDOC
+func (s *ArduinoCoreServerImpl) EnumerateMonitorPortSettings(context.Context, *rpc.EnumerateMonitorPortSettingsRequest) (*rpc.EnumerateMonitorPortSettingsResponse, error) {
+	return nil, status.New(codes.Unimplemented, "Not implemented").Err()
+}
+
+// Monitor FIXMEDOC
+func (s *ArduinoCoreServerImpl) Monitor(stream rpc.ArduinoCoreService_MonitorServer) error {
+	return status.New(codes.Unimplemented, "Not implemented").Err()
+}
diff --git a/i18n/data/en.po b/i18n/data/en.po
@@ -2923,7 +2923,7 @@ msgstr "no compatible version of %s tools found for the current os"
 msgid "no executable specified"
 msgstr "no executable specified"
 
-#: commands/daemon/daemon.go:96
+#: commands/daemon/daemon.go:98
 msgid "no instance specified"
 msgstr "no instance specified"
 

diff --git a/i18n/rice-box.go b/i18n/rice-box.go
diff --git a/rpc/cc/arduino/cli/commands/v1/commands.pb.go b/rpc/cc/arduino/cli/commands/v1/commands.pb.go
diff --git a/rpc/cc/arduino/cli/commands/v1/commands.proto b/rpc/cc/arduino/cli/commands/v1/commands.proto
@@ -25,6 +25,7 @@ import "cc/arduino/cli/commands/v1/common.proto";
 import "cc/arduino/cli/commands/v1/board.proto";
 import "cc/arduino/cli/commands/v1/compile.proto";
 import "cc/arduino/cli/commands/v1/core.proto";
+import "cc/arduino/cli/commands/v1/monitor.proto";
 import "cc/arduino/cli/commands/v1/upload.proto";
 import "cc/arduino/cli/commands/v1/lib.proto";
 
@@ -170,6 +171,13 @@ service ArduinoCoreService {
 
   // List the installed libraries.
   rpc LibraryList(LibraryListRequest) returns (LibraryListResponse);
+
+  // Open a monitor connection to a board port
  rpc Monitor(stream MonitorRequest) returns (stream MonitorResponse);
+
+  // Returns the parameters that can be set in the MonitorRequest calls
+  rpc EnumerateMonitorPortSettings(EnumerateMonitorPortSettingsRequest)
+      returns (EnumerateMonitorPortSettingsResponse);
 }
 
 message CreateRequest {}

diff --git a/rpc/cc/arduino/cli/commands/v1/commands_grpc.pb.go b/rpc/cc/arduino/cli/commands/v1/commands_grpc.pb.go