8000 Removed gRPC PlatformList command · arduino/arduino-cli@28cc496 · GitHub
[go: up one dir, main page]

Skip to content

Commit 28cc496

Browse files
cmagliealessio-perugini
authored andcommitted
Removed gRPC PlatformList command
1 parent 2031172 commit 28cc496

File tree

3 files changed

+0
-116
lines changed

3 files changed

+0
-116
lines changed

client_example/main.go

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,6 @@ func main() {
145145
log.Println("calling PlatformInstall(arduino:samd@1.6.19)")
146146
callPlatformInstall(client, instance)
147147

148-
// Now list the installed platforms to double check previous installation
149-
// went right.
150-
log.Println("calling PlatformList()")
151-
callPlatformList(client, instance)
152-
153148
// Upgrade the installed platform to the latest version.
154149
log.Println("calling PlatformUpgrade(arduino:samd)")
155150
callPlatformUpgrade(client, instance)
@@ -464,21 +459,6 @@ func callPlatformInstall(client rpc.ArduinoCoreServiceClient, instance *rpc.Inst
464459
}
465460
}
466461

467-
func callPlatformList(client rpc.ArduinoCoreServiceClient, instance *rpc.Instance) {
468-
listResp, err := client.PlatformList(context.Background(),
469-
&rpc.PlatformListRequest{Instance: instance})
470-
471-
if err != nil {
472-
log.Fatalf("List error: %s", err)
473-
}
474-
475-
for _, plat := range listResp.GetInstalledPlatforms() {
476-
// We only print ID and version of the installed platforms but you can look
477-
// at the definition for the rpc.Platform struct for more fields.
478-
log.Printf("Installed platform: %s - %s", plat.GetId(), plat.GetInstalled())
479-
}
480-
}
481-
482462
func callPlatformUpgrade(client rpc.ArduinoCoreServiceClient, instance *rpc.Instance) {
483463
upgradeRespStream, err := client.PlatformUpgrade(context.Background(),
484464
&rpc.PlatformUpgradeRequest{

commands/core/list.go

Lines changed: 0 additions & 90 deletions
This file was deleted.

commands/daemon/daemon.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -258,12 +258,6 @@ func (s *ArduinoCoreServerImpl) PlatformSearch(ctx context.Context, req *rpc.Pla
258258
return resp, convertErrorToRPCStatus(err)
259259
}
260260

261-
// PlatformList FIXMEDOC
262-
func (s *ArduinoCoreServerImpl) PlatformList(ctx context.Context, req *rpc.PlatformListRequest) (*rpc.PlatformListResponse, error) {
263-
platforms, err := core.PlatformList(req)
264-
return platforms, convertErrorToRPCStatus(err)
265-
}
266-
267261
// Upload FIXMEDOC
268262
func (s *ArduinoCoreServerImpl) Upload(req *rpc.UploadRequest, stream rpc.ArduinoCoreService_UploadServer) error {
269263
syncSend := NewSynchronizedSend(stream.Send)

0 commit comments

Comments
 (0)
0