[SAMD21] Don't issue a chip erase if address is 0

facchinm · facchinm · commit 89f3556a7618 · 2020-07-30T12:12:38.000+02:00
If a user selects "Nano33BLE" in the IDE but tries to flash a SAMD board, the commandline being used will not specify a base address, so the whole flash will be erased (the bootloader too)
diff --git a/src/D2xNvmFlash.cpp b/src/D2xNvmFlash.cpp
@@ -107,6 +107,10 @@ D2xNvmFlash::erase(uint32_t offset, uint32_t size)
 void
 D2xNvmFlash::eraseAll(uint32_t offset)
 {
+    if (offset == 0) {
+        // Not bailing out will provoke the bootloader to be erased
+        throw FlashEraseError();
+    }
     // Use the extended Samba command if available
     if (_samba.canChipErase())
     {

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,10 @@ D2xNvmFlash::erase(uint32_t offset, uint32_t size)`
`107`	`107`	`void`
`108`	`108`	`D2xNvmFlash::eraseAll(uint32_t offset)`
`109`	`109`	`{`
	`110`	`+ if (offset == 0) {`
	`111`	`+ // Not bailing out will provoke the bootloader to be erased`
	`112`	`+ throw FlashEraseError();`
	`113`	`+ }`
`110`	`114`	`// Use the extended Samba command if available`
`111`	`115`	`if (_samba.canChipErase())`
`112`	`116`	`{`