10000 MbedClient.cpp - invalid osPriority? and thread name · Issue #996 · arduino/ArduinoCore-mbed · GitHub
[go: up one dir, main page]
Skip to content

MbedClient.cpp - invalid osPriority? and thread name #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
megacct opened this issue Nov 10, 2024 · 0 comments · Fixed by #1039
Closed

MbedClient.cpp - invalid osPriority? and thread name #996

megacct opened this issue Nov 10, 2024 · 0 comments · Fixed by #1039

Comments

@megacct
Copy link
Contributor
megacct commented Nov 10, 2024 •
edited
Loading

reader_th = new rtos::Thread(osPriorityNormal - 2);
This appears to always give priority normal, which is good as any other priority seems to cause a hang. It would also be nice to have the thread named. If changed to:
reader_th = new rtos::Thread(osPriorityNormal - 2, OS_STACK_SIZE, nullptr, "readSocket");
then a compile error is returned for the priority.
I would suggest this should be changed to:
reader_th = new rtos::Thread(osPriorityNormal, OS_STACK_SIZE, nullptr, "readSocket");
@megacct megacct changed the title MbedClient.cpp - invalid osPriority and thread name MbedClient.cpp - invalid osPriority? and thread name Nov 10, 2024
@megacct megacct mentioned this issue Mar 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update MbedClient.cpp fix readSocket osPriority and name the thread megacct/ArduinoCore-mbed
1 participant
@megacct
0