8000 In stream.cpp add readln, to simplify reading Windows and Linux text files · Issue #251 · arduino/ArduinoCore-API · GitHub
[go: up one dir, main page]

Skip to content

In stream.cpp add readln, to simplify reading Windows and Linux text files #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zingzog opened this issue May 20, 2025 · 0 comments
Open

Comments

@zingzog
Copy link
zingzog commented May 20, 2025

API component

stream.cpp

Description

Text files can be read using readBytesUntil with the LineFeed character but with Windows files the CR character has to be dealt with. readln would terminate on LF and ignore CR so that the user just sees c-strings representing the text on each line.

Is this a breaking change?

No

Additional information

I have been using this code as a solution:
`// as readBytes but terminates on LF (13), ignores CR (10)
// terminates if length characters have been read, timeout, or if the terminator character detected
// returns the number of characters placed in the buffer (0 means no valid data found)

int Stream::readln(char *buffer, int length) {
int index = 0;
int c = 0;
while (index < length) {
c = timedRead();
if (c < 0 || c == 13) {
break;
}
if (c != 10){
*buffer++ = (char)c;
index++;
}
}
*buffer = '\0';
if (c < 0){
return -1;
}else{
return index; // return number of characters, not including null terminator
}
}`

As mentioned earlier, text files can be read using readBytesUntil with the LineFeed character but with Windows files the CR character has to be dealt with. The advantages of readln are that:

  • it neatly encapsulates the issues
  • it works with both LF and CRLF terminated strings
  • no additional cleanup work needed by the programmer

A quick Google search shows a number of questions in Stack Overflow, etc. requesting a solution to reading lines from text files.
I am using the function with LittleFS to read configuration key=value pairs from text files, and to read lines from html files for modification, and removal.
For me it is simple, and works reliably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant
0