test: fix buffer overflow in String::getBytes test

tttapa · tttapa · commit 4db89597b09f · 2023-07-31T20:49:18.000+02:00
diff --git a/test/src/String/test_characterAccessFunc.cpp b/test/src/String/test_characterAccessFunc.cpp
@@ -45,10 +45,11 @@ TEST_CASE ("Testing String::getBytes(unsigned char, unsigned int, unsigned int)"
 
   WHEN("Valid operation") {
     arduino::String str("Hello");
-    unsigned char buf[2];
+    unsigned char buf[3];
     str.getBytes(buf, 5, 3);
     REQUIRE(buf[0] == 'l');
     REQUIRE(buf[1] == 'o');
+    REQUIRE(buf[2] == '\0');
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -45,10 +45,11 @@ TEST_CASE ("Testing String::getBytes(unsigned char, unsigned int, unsigned int)"`
`45`	`45`
`46`	`46`	`WHEN("Valid operation") {`
`47`	`47`	`arduino::String str("Hello");`
`48`		`- unsigned char buf[2];`
	`48`	`+ unsigned char buf[3];`
`49`	`49`	`str.getBytes(buf, 5, 3);`
`50`	`50`	`REQUIRE(buf[0] == 'l');`
`51`	`51`	`REQUIRE(buf[1] == 'o');`
	`52`	`+ REQUIRE(buf[2] == '\0');`
`52`	`53`	`}`
`53`	`54`	`}`
`54`	`55`