pacstrap: error out earlier, on invalid directory

evelikov · evelikov · commit c72a394de79b · 2023-03-26T19:03:33.000+01:00
Signed-off-by: Emil Velikov &lt;emil.l.velikov@gmail.com&gt;
diff --git a/pacstrap.in b/pacstrap.in
@@ -130,7 +130,11 @@ done
 shift $(( OPTIND - 1 ))
 
 (( $# )) || die "No root directory specified"
-newroot=$1; shift
+newroot=$1
+shift
+
+[[ -d $newroot ]] || die "%s is not a directory" "$newroot"
+
 pacman_args+=("$pacmode" "${@:-base}" --config="$pacman_config")
 
 if (( ! hostcache )); then
@@ -141,8 +145,6 @@ if (( ! interactive )); then
   pacman_args+=(--noconfirm)
 fi
 
-[[ -d $newroot ]] || die "%s is not a directory" "$newroot"
-
 if (( unshare )); then
   setup=unshare_setup
   $mount_unshare bash -c "$(declare_all); pacstrap"
