#250 deleteById by contract must not throw an exception for unknown id

aburmeis · aburmeis · commit 6fb52135c079 · 2023-08-07T18:00:58.000+02:00
diff --git a/src/main/java/com/arangodb/springframework/repository/SimpleArangoRepository.java b/src/main/java/com/arangodb/springframework/repository/SimpleArangoRepository.java
@@ -29,6 +29,7 @@
 import com.arangodb.springframework.core.util.AqlUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+import org.springframework.dao.InvalidDataAccessResourceUsageException;
 import org.springframework.data.domain.*;
 import org.springframework.data.mapping.PersistentPropertyAccessor;
 import org.springframework.data.repository.query.FluentQuery;
@@ -155,7 +156,11 @@ public long count() {
 	 */
 	@Override
 	public void deleteById(final ID id) {
-		arangoOperations.delete(id, domainClass);
+		try {
+			arangoOperations.delete(id, domainClass);
+		} catch (InvalidDataAccessResourceUsageException notFound) {
+			// ignored by contract
+		}
 	}
 
 	/**
diff --git a/src/test/java/com/arangodb/springframework/repository/ArangoRepositoryTest.java b/src/test/java/com/arangodb/springframework/repository/ArangoRepositoryTest.java
@@ -4,11 +4,7 @@
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.is;
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.LinkedList;
-import java.util.List;
-import java.util.Optional;
+import java.util.*;
 
 import org.junit.jupiter.api.Test;
 import org.springframework.data.domain.*;
@@ -90,6 +86,7 @@ public void deleteByIdTest() {
 		repository.deleteById(johnId);
 		assertThat(repository.existsById(bob.getId()), equalTo(true));
 		assertThat(repository.existsById(johnId), equalTo(false));
+		repository.deleteById("12345678");
 	}
 
 	@Test
