[Bugfix] Use MD5 instead of SHA256 for CRD Checksums (#1653)

ajanikow · web-flow · commit 3a511c3fd793 · 2024-04-30T10:49:26.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - (Bugfix) Prevent unexpected rotation in case of SecurityContext change
 - (Bugfix) Ensure PDB is created
 - (Bugfix) Fix Schema Apply Checksum
+- (Bugfix) Use MD5 instead of SHA256 for CRD Checksums
 
 ## [1.2.40](https://github.com/arangodb/kube-arangodb/tree/1.2.40) (2024-04-10)
 - (Feature) Add Core fields to the Scheduler Container Spec
diff --git a/pkg/crd/crds/crds.go b/pkg/crd/crds/crds.go
@@ -48,10 +48,10 @@ func (d DefinitionData) schemaDefinitionLoader() util.Loader[crdSchemas] {
 
 func (d DefinitionData) Checksum() (definition, schema string) {
 	if len(d.definition) > 0 {
-		definition = util.SHA256(d.definition)
+		definition = util.MD5(d.definition)
 	}
 	if len(d.schemaDefinition) > 0 {
-		schema = util.SHA256(d.schemaDefinition)
+		schema = util.MD5(d.schemaDefinition)
 	}
 	return
 }
diff --git a/pkg/util/checksum.go b/pkg/util/checksum.go
@@ -21,6 +21,7 @@
 package util
 
 import (
+	"crypto/md5"
 	"crypto/sha256"
 	"fmt"
 
@@ -35,6 +36,14 @@ func SHA256(data []byte) string {
 	return fmt.Sprintf("%0x", sha256.Sum256(data))
 }
 
+func MD5FromString(data string) string {
+	return MD5([]byte(data))
+}
+
+func MD5(data []byte) string {
+	return fmt.Sprintf("%0x", md5.Sum(data))
+}
+
 func SHA256FromJSON[T interface{}](a T) (string, error) {
 	d, err := json.Marshal(a)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -48,10 +48,10 @@ func (d DefinitionData) schemaDefinitionLoader() util.Loader[crdSchemas] {`
`48`	`48`
`49`	`49`	`func (d DefinitionData) Checksum() (definition, schema string) {`
`50`	`50`	`if len(d.definition) > 0 {`
`51`		`- definition = util.SHA256(d.definition)`
	`51`	`+ definition = util.MD5(d.definition)`
`52`	`52`	`}`
`53`	`53`	`if len(d.schemaDefinition) > 0 {`
`54`		`- schema = util.SHA256(d.schemaDefinition)`
	`54`	`+ schema = util.MD5(d.schemaDefinition)`
`55`	`55`	`}`
`56`	`56`	`return`
`57`	`57`	`}`