10000 Make AQL modification operations asynchronous by goedderz · Pull Request #21068 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Make AQL modification operations asynchronous #21068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jun 20, 2024
Merged

Make AQL modification operations asynchronous #21068

merged 29 commits into from
Jun 20, 2024

Conversation

goedderz
Copy link
Member
@goedderz goedderz commented Jun 17, 2024 •
edited
Loading

Scope & Purpose

Make AQL modification operations asynchronous.

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • 📖 CHANGELOG entry made

Related information

Up-front work for this:

Related previous PRs:

goedderz added 16 commits June 6, 2024 11:36
@goedderz
Try to avoid synchronous waiting in AQL, and fix transaction lifetime…
c787f51 
… issues
@goedderz
Make the Query's resource monitor a shared_ptr
a610077
@goedderz
Merge branch 'devel' of github.com:arangodb/arangodb into feature/mak…
e16a0b4 
…e-query-resource-monitor-shared
@goedderz
Revert "Try to avoid synchronous waiting in AQL, and fix transaction …
2bd1475 
…lifetime issues"

This reverts commit c787f51.
@goedderz
Merge branch 'feature/make-query-resource-monitor-shared' into featur…
6537d4b 
…e/make-aql-modifications-async
@goedderz
Merge branch 'devel' of github.com:arangodb/arangodb into feature/mak…
ee1b40d 
…e-query-resource-monitor-shared
@goedderz
Included review comments
effb1b8
@goedderz
Merge branch 'feature/make-query-resource-monitor-shared' of github.c…
b3ca915 
…om:arangodb/arangodb into feature/make-aql-modifications-async
@goedderz
Shorten BuilderLeaser lifetimes, and copy vocbase name
5096702
@goedderz
Added a maintainer-mode assertion
843f341
@goedderz
Serialize DBServer modification operations
39522be
@goedderz
Merge branch 'devel' of github.com:arangodb/arangodb into feature/mak…
193dc63 
…e-aql-modifications-async
@goedderz
Fixed gtests and CE compilation
413fabc
@goedderz
Fixed gtests
68556fd
@goedderz
Clean references to SharedAqlItemBlockPtr early enough
261fba2
@goedderz
Fixed CE compilation
807fcb6
@goedderz goedderz added this to the devel milestone Jun 17, 2024
@goedderz goedderz self-assigned this Jun 17, 2024
@goedderz goedderz requested review from a team as code owners June 17, 2024 14:09
@cla-bot cla-bot bot added the cla-signed label Jun 17, 2024
Base automatically changed from feature/make-query-resource-monitor-shared to devel June 18, 2024 08:36
jsteemann
jsteemann reviewed Jun 20, 2024
View reviewed changes
jsteemann
jsteemann reviewed Jun 20, 2024
View reviewed changes
jsteemann
jsteemann approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor
@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goedderz and others added 5 commits June 20, 2024 09:53
@goedderz @jsteemann
Update arangod/Transaction/Methods.cpp
ec9f11b 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@goedderz @jsteemann
Update arangod/Transaction/Methods.cpp
d999326 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@goedderz
Merge branch 'devel' of github.com:arangodb/arangodb into feature/mak…
8ee9cc7 
…e-aql-modifications-async
@goedderz
Added CHANGELOG entry
d8f6c20
@goedderz
Merge branch 'feature/make-aql-modifications-async' of github.com:ara…
d9bd683 
…ngodb/arangodb into feature/make-aql-modifications-async
jsteemann
jsteemann approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor
@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpoeter mpoeter merged commit a789fad into devel Jun 20, 2024
7 checks passed
@mpoeter mpoeter deleted the feature/make-aql-modifications-async branch June 20, 2024 16:56
This was referenced Jun 24, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteemann jsteemann jsteemann approved these changes

Assignees

@goedderz goedderz

Labels
cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
3 participants
@goedderz @jsteemann @mpoeter
0