8000 make AQL modification operations blocking again by jsteemann · Pull Request #14795 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

make AQL modification operations blocking again #14795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2021
Merged

make AQL modification operations blocking again #14795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions arangod/Aql/SimpleModifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,13 @@ ExecutionState SimpleModifier<ModifierCompletion, Enable>::transact(transaction:

auto result = _completion.transact(trx, _accumulator.closeAndGetContents());

// we are currently waiting here for the `result` future to get
// ready before we continue. this makes the AQL modification
// operations blocking as in previous versions of ArangoDB.
// TODO: fix this and make it truly non-blocking (requires to
// fix some lifecycle issues for AQL queries first).
result.wait();

if (result.isReady()) {
_results = std::move(result.get());
return ExecutionState::DONE;
Expand Down
0