make statistics available in metrics API no matter what #14702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if `--server.statistics` was set to `false`, the metrics API did not return any values provided by the StatisticsFeature, as the statistics were turned off completely. This prevented the metrics API from returning some useful process statistics (e.g. memory usage, number of threads etc.). This change now enables these process statistics as well as a few others in metrics regardless of the setting of `--server.statistics`. This was already the case in 3.8 and devel, but 3.7 still behaved slightly differently
8 tasks
8 tasks
cpjulia
approved these changes
Aug 27, 2021
| @@ -43,13 +45,16 @@ | |||
| #include "Statistics/RequestStatistics.h" | |||
| #include "Statistics/ServerStatistics.h" | |||
| #include "Statistics/StatisticsWorker.h" | |||
There was a problem hiding this comment.
is this header still in use here?
There was a problem hiding this comment.
#include "Statistics/StatisticsWorker.h"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Follow-up to APM-106.
Previously, if
--server.statisticswas set tofalse, the metrics APIdid not return any values provided by the StatisticsFeature, as the
statistics were turned off completely. This prevented the metrics API
from returning some useful process statistics (e.g. memory usage, number
of threads etc.).
This change now enables these process statistics as well as a few others
in metrics regardless of the setting of
--server.statistics.This was already the case in 3.8 and devel, but 3.7 still behaved
slightly differently.
For 3.8 and devel no changes are required, but there will be an additional
test added for these versions.
Backports:
Related Information
Testing & Verification