-
Notifications
You must be signed in to change notification settings - Fork 853
Fixed LogsView re-visit issue #14519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy stateme 8000 nt. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm too
…ix-3.8/ui-logs-view-removed-dom-element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Scope & Purpose
Potentially due to a few changes in our build environment, a new issue occured:
When "tabbing" out of the LogsView, the main/central "#content" DIV element got removed which lead to
logical errors. This element is a mandatory element and is not allowed to be removed.
This PR solves:
The issue itself
Adds node v16 support (raise of two sass modules, see package.json)
Adds missing "span" closing bracket
Removed obsolete console logs
💩 Bugfix (requires CHANGELOG entry)
📖 CHANGELOG entry made
Backports:
Related Information
Testing & Verification
(Please pick either of the following options)