8000 Fixed LogsView re-visit issue by hkernbach · Pull Request #14519 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Fixed LogsView re-visit issue #14519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 29, 2021
Merged

Fixed LogsView re-visit issue #14519

merged 8 commits into from
Jul 29, 2021

Conversation

@hkernbach
Copy link
Member
@hkernbach hkernbach commented Jul 19, 2021

Scope & Purpose

Potentially due to a few changes in our build environment, a new issue occured:
When "tabbing" out of the LogsView, the main/central "#content" DIV element got removed which lead to
logical errors. This element is a mandatory element and is not allowed to be removed.

This PR solves:

  • The issue itself

  • Adds node v16 support (raise of two sass modules, see package.json)

  • Adds missing "span" closing bracket

  • Removed obsolete console logs

  • 💩 Bugfix (requires CHANGELOG entry)

  • 📖 CHANGELOG entry made

Backports:

  • Backports required for: devel

Related Information

Testing & Verification

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested

@hkernbach hkernbach added this to the 3.8 milestone Jul 19, 2021
@hkernbach hkernbach requested review from KVS85, ajurdak and pluma July 19, 2021 13:36
pluma
pluma approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor
@pluma pluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hkernbach hkernbach mentioned this pull request Jul 19, 2021
Merged
3 tasks
ajurdak
ajurdak approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor
@ajurdak ajurdak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too

@KVS85 KVS85 added the 3 UI ArangoDB Web Interface (frontend/Aardvark) label Jul 28, 2021
KVS85
KVS85 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor
@KVS85 KVS85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KVS85 KVS85 merged commit 6967077 into 3.8 Jul 29, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/ui-logs-view-removed-dom-element branch July 29, 2021 12:00
@MDAlFattah MDAlFattah mentioned this pull request Aug 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KVS85 KVS85 KVS85 approved these changes

+2 more reviewers

@pluma pluma pluma approved these changes

@ajurdak ajurdak ajurdak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hkernbach hkernbach

Labels

3 UI ArangoDB Web Interface (frontend/Aardvark) 9 Review Required

Projects

None yet

Milestone

3.8

Development

Successfully merging this pull request may close these issues.

5 participants

@hkernbach @pluma @KVS85 @ajurdak
0