Reduce the amount of exception macros #14504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/replication-2.0
…b into feature/replication-2.0
…b into feature/replication-2.0
…ces where required. Make sure self mutex guard is always released asap.
Co-authored-by: Manuel Pöter <manuel.poeter@leanfive.com>
Co-authored-by: Manuel Pöter <manuel.poeter@leanfive.com>
Dronplane
added a commit
that referenced
this pull request
Oct 5, 2021
* Soft coordinator shutdown (#14264) * Initial working version for AQL cursors. * Prevent multiple soft shutdowns. * Finish integration tests for soft shutdown. * Report progress on soft shutdown. * Add tests for soft shutdown progress. * Add test for AQL cursors being blocked by a soft shutdown. * Add transactions to the mix. * Add async job tracking. * Add Pregel tracking. * Add tracking of low prio queue and ongoing. * Apply suggestions from code review Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Backport rocksdb diskspace bugfix (#14352) * Backport bugfix from upstream rocksdb repository for calculating the free disk space for the database directory. Before the bugfix, rocksdb could overestimate the amount of free space when the arangod process was run as non-privileged users. * Fix URL request parsing. (#14357) * fixes warnings about potentially uninitialized vars with g++11 (#14366) * Slightly improve specific warning messages for better readability. (#14360) * Bug fix/fix devsup 753 (#14373) * added test * apply fix * Update CHANGELOG * Apm 55 (#14364) * gauss decay * 3 functions are ready * fix for win build * changes after code review * changelog * changes in functions + js tests + range test * renamed functions * Bug fix/user manager version race (#14382) Fixes ES-863 * Update CHANGELOG * Improve usability of hidden options: (#14393) `--help` mentions that these exist and how to display them. * hides wrong label in the statistics memory tooltip + node 16 build support (#14389) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Fixes for shard synchronization (#14384) Fixes for shard synchronization Co-authored-by: mpoeter <manuel@arangodb.com> Co-authored-by: Max Neunhoeffer <max@arangodb.com> * Fix potential use after free. * fix ownership issue * Add `/_admin/metrics/v2` DocuBlock (#14324) (#14412) * Add deprecation warning to old metrics endpoint * Add DocuBlock for /_admin/metrics/v2 * Try to make plain curl examples shortable * Strip whitespace from line * Update get_admin_metrics_v2.md * Fix DEVSUP-799 (#14401) * Fix DEVSUP-799 * Fixed DEVSUP-799: unique vertex getter may point to invalid memory after being resetted, resulting in undefined behavior for traversals returning unique vertices from inner FOR loops. * added test * try to fix non-maintainer compilation * try to fix non-maintainer compilation Co-authored-by: Vadim <vadim@arangodb.com> * Update arangosync to 2.4.0 * added test for addOperation returning an error (#14410) * Add new chaos test suite. (#14406) * Add Intel Comet Lake to the microarchitecture detection script (#14414) * Add Intel Comet Lake to the microarchitecture detection script * retire cpu microarchitectures older than minimal required(sandy-bridge) * Fail if CPU is older than Sandy Bridge and ASM optimizations are enabled. * fix error: actually set march to sandy-bridge * Update ArangoDB Starter to 0.15.1-preview-1 * Bug fix/presupp 358 (#14404) * Introduce callstack splitting to avoid stackoverflows with large AQL queries (#14351) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * adjust wording as in 3.8 PR * partial revert of commit 140beed * also revert some added tests * Update ArangoDB Starter to 0.15.1-preview-2 * Fix soft shutdown test on Windows (#14374) arangosh connection should be reinitialized after a Coordinator restart * Sort list of queries in web UI for display (#14428) Co-authored-by: Simran <Simran-B@users.noreply.github.com> * Removed redirects for some cluster rest handler (#14425) Co-authored-by: jsteemann <jsteemann@users.noreply.github.com> * Search 161 (#14413) * initial changes * new tests * clean up * Update arangod/Aql/AqlFunctionFeature.cpp Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com> * fix for test * fix for tests * changelog + changes for decay funcs * upd for changelog Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com> * Revive startup parameter `--server.session-timeout` (#14118) Co-authored-by: Tobias Gödderz <tobias@arangodb.com> * added a TTL for Pregel conductors, plus GC (#14311) * Added empty graph tests for generic traversal test. (#14271) * enable assertion in QueryContext::collections() (#14448) * Update ArangoDB Starter to 0.15.1-preview-3 * Soft coordinator shutdown documentation (#14356) * Add documentation for soft coordinator shutdown. * Add introduced in. * Apply suggestions from code review * Update get_api_shutdown.md * Update get_api_shutdown.md * Update delete_api_shutdown.md * Update get_api_shutdown.md Co-authored-by: Simran <Simran-B@users.noreply.github.com> * Fix numeric overflow in WINDOW cost estimtation (#14464) * Fix numeric overflow in AQL WINDOW node cost estimation if the number of preceding rows was set to `unbounded`. * Enable -Og for debug builds (#14438) * [BTS-491][devel] ArangoRestore connect Retry (#14461) * Fix potential memleak in Pregel conductor garbage collection. (#14466) * enable process metrics on agents (#14453) * Following term id (#14405) * Implement following term id. * Add test. Co-authored-by: Jan <jsteemann@users.noreply.github.com> * fix index selection with prefix indexes (#14424) Co-authored-by: Manuel Pöter <manuel.poeter@leanfive.com> * Fix ArangoAgency::version() (#14476) * Fix ArangoAgency::version(), which always returned an empty string instead of the agency's correctly reported version. This also fixes the agency version in the startup log messages of the cluster. * Added new command line-option `--version-json`. This will return the … (#14383) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * APM-112: prevent invalid use of OPTIONS in AQL queries (#14467) * add more output to assertion * fix macros (#14481) * lower takeover leadership current log level (#14379) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Bug fix/non recursive plan handling (#14475) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Added (gauge) metric "rocksdb_read_only" (#14470) Co-authored-by: Tobias Gödderz <tobias@arangodb.com> * fix locking of write transactions on DB servers (#14450) * fix typo * Feature/guarded mutex (#13996) * quod licet iovi non licet bovi (#14490) * remove duplicate log message * Upgrade non-breaking JS dependencies (#14152) * Upgrade non-breaking JS dependencies accepts 1.3.5 -> 1.3.7 ansi_up 4.0.3 -> 5.0.1 chalk 1.1.3 -> 4.1.1 error-stack-parser 2.0.2 -> 2.0.6 highlight.js 9.15.6 -> 10.7.2 http-errors 1.7.2 -> 1.8.0 js-yaml 3.13.1 -> 4.1.0 lodash 4.17.13 -> 4.17.21 mime-types 2.1.22 -> 2.1.30 netmask 1.0.6 -> 2.0.2 qs 6.7.0 -> 6.10.1 range-parser 1.2.0 -> 1.2.1 timezone 1.0.22 -> 1.0.23 type-is 1.6.16 -> 1.6.18 underscore 1.9.1 -> 1.13.1 Closes #14120. * Downgrade js-yaml * Bump deps iconv-lite 0.4.24 -> 0.6.2 semver 6.0.0 -> 7.3.5 media-typer 0.3.0 -> content-type 1.0.4 * Add note to CHANGELOG * Add content-type license / remove media-typer license * Replace underscore imports with lodash But mostly it wasn't used at all so the useless imports have been removed. * Remove marked, underscore * Add note about underscore * Remove underscore/marked licenses * Update CHANGELOG * Add underscore back Apparently some of our demo services use this, breaking tests. * Fix Foxx type internals * Bump deps * npm audit fix * Keep mime type parameters * xmldom -> 0.6.0 (BREAKING) * Revert "Keep mime type parameters" This reverts commit 261df1d. This commit breaks shell-foxx-swagger-spec.js * Extract used parts of mocha * Convert to classes * Better module load error messages * Move mocha.js to mocha/index.js * Extract reporters, interfaces, utils * Remove mocha dep * Add mocha copyright headers * jslint * Add ms This is used by the mocha internals and was dropped in the rebase. * Restore cause attribute This previously broke a testcase. * Fix utils/jslint.sh * Fix test title * Fix missing reporters exports This is actually used in the Foxx HTTP API app. * Remove please upgrade rest handler. Useless. (#14495) * Replicated Logs Companion PR (#14484) * improve shell-aql-query-setup-timeout test (#14489) - added a missing `fail()` - allow 2 different errors codes (both are possible) * Fix handling of empty WAL files with encryption at rest (#14477) * Fix startup issues with encryption-at-rest enabled when there were empty (0 byte) RocksDB WAL files present. Such empty files caused RocksDB to abort the startup, reporting corruption. However, empty WAL files are possible in case of server crashes etc. Now, if a WAL file is completely empty, there will be no attempt to read the encryption meta data from it, so the startup succeeds. * Fix invalid assertion and always remove blocker object on replication failure (#14500) * Add limits for AQL query complexity (#14480) * Improve internal AQL and transaction timeouts (#14283) * Remove chalk (#14505) * Remove chalk * Add chalk back * Remove extra files * pragma oncify (#14507) * BTS-519: avoid holding 2 mutexes at the same time (#14511) * remove stray semicolon * fix a g++-9 compile warning for a potentially uninitialized var (#14509) * Fixed BTS-408 (#14513) * Improve startup file copying of JavaScript files (#14512) * Restore media-typer, upgrade mocha to 6.2.3 (#14517) * Fix duplicate log id in ExecutionBlockImpl (#14522) * simplify blocker handling (#14508) * JavaScript file handling improvements: (#14529) * JavaScript file handling improvements: * adjust the path to node_modules to the local copy if appropriate * add adjusted paths (to local copy) to JavaScript allow lists * Remove original paths from JavaScript allow lists When resetting startup directory and node_modules paths to the copies inside the database directory, do not add the original paths to the JavaScript allow lists. * Use lower defaultMaxNodesPerCallstack for Mac. (#14533) * Use lower defaultMaxNodesPerCallstack for Mac. * Update CHANGELOG. * Code cleanup (linting, formatting, deduping, and minor refactoring. (#14541) * Improve query memory usage tracking for graph operations (#14535) * Improving the router initialization checking logic: polling --> evented (#14547) * APM-132: Clean up collection statuses (#14539) * Update ArangoDB Starter to 0.15.1-preview-4 * Bug fix/refactor rocks db transaction state and rocks db methods (#14543) * Update RestoreFeature.cpp * Update CHANGELOG * Update CHANGELOG * Remove mutexes from Logging (#14550) Co-authored-by: mpoeter <manuel@arangodb.com> * experiment to check if SyncWAL works on Windows (#14551) * Agency hasAsXXX using std::optional (#14376) * do not use -n on echo, this might not be supported and is not neseccary (#14292) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * attempt to pacify clang-1100 (#14554) * disable a test that only works with failure points enabled (#14552) * Update arangosync to 2.5.0 * Removed unused function declaration (#14556) * Update ArangoDB Starter to 0.15.1 * Search-216 - Distance functions in AQL (#14555) * initial commit * other distances + tests + js * added info in changelog * minor changes * fix a test which didn't run without failure tests * timely update of database servers in cluster cache (#14569) * database and coordinator server lists need be updated for timely update of cluster info * Add test cases for _admin/metrics/v2 endpoint in cluster mode (#14446) * add test cases for _admin/metrics/v2 endpoint in cluster mode * check that metrics from desired server are returned when requesting via coordinator use 2 coordinator servers for shell_client test suite ensure that server is recovered before going on with other tests * Fix jslint * Update shell-promtool-cluster.js Co-authored-by: Vadim Kondratyev <vadim@arangodb.com> * Cleanup random stuff (#14563) * Simplify management of CollectionNameResolver ownership in transaction context. * Prefer getters over accessing foreing data members. * Remove unused file. * Reduce code duplication. * Use find member function instead of std::find. * Reduce code duplication. * Reduce code duplication. * address review comments Co-authored-by: jsteemann <jsteemann@users.noreply.github.com> * better URL-encoding in UI (#14252) * only disable a startup warning for actually wrong configs (#14579) Previously a startup warning was displayed if any of 2 kernel memory management config files had a wrong value. The warning listed both files are wrong. Now a warning is printed only for the actually affected file(s). * fixed path (#14586) * Feature/refactor arangobench (#14548) * Started refactoring with Velocypack * Test for account email change * Integrated Velocypack to document-import and removed comments that were added for testing * Integrated arangobench to Velocypack * Fixed compilation bug by adding const to the payload function definitions, formatted, removed unused variables * Removed unnecessary indentation from file * Fixed typos in document testkeys * Apply suggestions from code review Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Applied suggested changes on review * Added log topic BENCH * Merged url, type and payload functions into one, changed type of LOG messages from FIXME to BENCH, added description to testcases * Fixes for results calculations fix calculation of percentiles with batch size > 0 fix calculation of avg request time * simplify some test cases * slightly clean up API * simplify request handling * simplify test cases * simplify test cases * simplify test cases * Removed escape for character % within a string that was causing compilation error for Windows * reduce formatting differences in main files * micro optimizations * set some velocypack Options for Builder * allow recycling of SimpleHttpResult objects * add "bench" log topic * unrolled case-insensitive comparison * CHANGELOG * fix gtest * Update arangosh/Benchmark/testcases/AqlInsertTest.h Co-authored-by: Manuel Pöter <manuel.poeter@leanfive.com> * address review comments * fix error counters for batching * fix some out-of-range casts reported by ASan Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: Manuel Pöter <manuel.poeter@leanfive.com> * Reduce memory usage of Merkle trees (#14549) Co-authored-by: Max Neunhoeffer <max@arangodb.com> * Follow-up for APM-79 (#14584) * Fix BTS-527 (#14538) * fix potential coordinator miss on existing databases * we're catching a bad alloc on a string assignment * fix of fix potential coordinator miss on existing databases * fix of fix potential coordinator miss on existing databases * vs warnings * Bug fix/UI logs view removed dom element (#14520) * removed console log, added missing closing span, fixed use of wrong remove method in loggerView * added changelog * Update CHANGELOG * Rebuild UI Co-authored-by: Vadim <vadim@arangodb.com> * Bug-fix eslint (#14335) * fix for windows install * Update CHANGELOG * Adjust no-eslint to current packages state * Add npm module delisting script (for js/node modules) * Remove unreliable node modules regex * Fix typo * Fix typo * Clear js/node/package-lock.json-no-* * Update package.json-no-eslint and package-lock.json-no-eslint with delisted eslint Co-authored-by: Vadim <vadim@arangodb.com> * Repair GEO_INTERSECTS (#14492) * Add bad tests. * Fix intersection bug with LngLatRect and Polygon. * Deduplicated code with intersectRectPolygon function. * Deduplicated code using intersectMultiPointsRegion. * Add more implementations, fix tests. * Add more tests with latlngrect and polygon. * Finishing touches. Make point/line and friends throw exceptions. * Avoid some memory allocations. * CHANGELOG. * Suggestions by gnusi. Co-authored-by: maierlars <lars@arangodb.com> Co-authored-by: gnusi <gnusi@arangodb.com> * Update InstallArangoDBJSClient.cmake * fix BTS-536 "Upgrading without rest-server is aborted by error". (#14606) * fix BTS-536 "Upgrading without rest-server is aborted by error". Now stating `--server.rest-server false` does not require the additional `--console` argument for upgrading a server. * fixed it * Revert change from `-O0` to `-Og` (#14613) * Change optimization level for debug builds back to `-O0` (from `-Og`) because `-Og` seems to cause debuggability issues in some environments. * bts 542: huge memory use agent (#14614) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Introducing Replicated Logs (#14486) * Search-37 - optimizer rules (#14585) * optimization for calculation * some fixes * some fixes + tests * now we can reset and use optimization * fixes from code review * Another optimizations * Another changes from review * pointers to implementation * another fixes * another one * added changelog * Fix BTS-539 (#14612) * move profileQuery unregistering after the sync * Update CHANGELOG * address review comments Co-authored-by: Vadim <vadim@arangodb.com> * Fixing immer gcc x.1 compilation issues. (#14620) * fixed issue #14592: IS_NULL(@x) isn't recognized as a constant expression (#14603) * Bug fix/replicated logs missing column family (#14622) Co-authored-by: jsteemann <jsteemann@users.noreply.github.com> * Fix duplicate log id (#14625) * update README_maintainers (#14627) Co-authored-by: Andreas Jurdak <andreas@jurdak.at> * Disable replication 2.0. (#14629) * improve Pregel log messages by giving them more context (#14631) * Added more recent architectures to OptimizeForArchitecture (#14628) * Added more recent architectures to OptimizeForArchitecture * Update README_maintainers.md Co-authored-by: Vadim <vadim@arangodb.com> * Bug fix/graph node keep all flags on clone (#14635) * Bug fix/begin trx disjoint (#14641) * Added ChangeLogEntry (#14647) * use more sensible values for timeouts/renewals (#14638) * Improvements for Pregel memory-mapped files (#14636) * Add -fstandalone-debug for Clang Debug builds (#14439) * Suppress a useless warning (#14624) * make AQL modification operations async (#14644) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Fix erroneous "access after data-modification" errors (#14646) * Fix shutdown in --console mode (#14621) * Fixed a velocypack type error in maintenance::reportInCurrent (#14361) * Added MutexGuard::unlock(), fixed tryLockedGuard, added tests (#14652) * Reduce the amount of exception macros (#14504) * Feature/iresearch test latest format (#14542) * upgrade iresearch * update vpack * adjusting ArangoSearch internals * wip * wip * add ugly kludge * more ugly kludge * remove redundant vpack registartions for analyzer * flags usage fixes * wip * build fixes * wip * fix Geo equals * update from upstream * rework field feature storage * fix some tests * fix tests * do not log error at shutdown * wip * update iresearch * fix tests * add js tests for newly created analyzers * add more tests * update iresearch from upstream * attempt to fix msvc/mac build * wip * wip * wip * add missing header * fix compilation * fix build * fix msvc build * wip * wip * wip * wip * wip * wip * update iresearch from upstream * fix test * adjust js tests * update iresearch changelog Co-authored-by: Andrey Abramov <andrey@arangodb.com> * Improve supportability (#14639) * Improve supportability * Added metrics for the number of errors and warnings logged: - `arangodb_logger_warnings_total`: total number of warnings (WARN messages) logged since server start. - `arangodb_logger_errors_total`: total number of errors (ERR messages) logged since server start. * Added REST API `/_admin/support-info` to retrieve deployment information. As this API may reveal sensitive data about the deployment, it can only be accessed from inside the system database and only if `--server.harden` is not set. The API can also be turned off entirely using the new startup option flag `--server.support-api`. * let support-info requests through * handle active failover cases * adjust CHANGELOG * added tests * added tests for startup option * rename startup option * remove redundant code * extend support info API tests * add tests * remove leftover conflict marker * Add DocuBlock with single server and cluster examples * HTTP 404 in case the support info API is turned off HTTP 403 if permissions are insufficient, but that error can be raised for any endpoint Co-authored-by: Simran Spiller <simran@arangodb.com> * fix a typo in a parse error message (#14666) * Remove fixPrototypeChain agency migration (#14658) * Remove fixPrototypeChain code. This was fixing a very rare user configuration in the collection setup and was introduced in 3.2. This change will make it impossible to upgrade from <= 3.1 directly to 3.9, provided somebody has a chain of `distributeShardsLike` settings, which is OK. * CHANGELOG. * suppress intentional failures for cppcheck tests (#14665) * Fix wrong assertion in fuerte (#14660) * Move assertion to the right place where the model has it. * CHANGELOG. * Adjust model and code one more time. * Revert JSUnity improvement, testCase names now need to be unique per file again. :sad: (#14659) * docs for APM-132 (#14675) * improvements for index creation (#14653) Co-authored-by: Manuel Pöter <manuel.poeter@leanfive.com> Co-authored-by: Max Neunhöffer <max@arangodb.com> * Increase default number of threads for client tools (#14673) * Change the default value for the `--threads` startup parameter of the following client tools from previously 2 to the maximum of 2 and the number of available CPU cores: - arangodump - arangoimport - arangorestore * Add more checks to YAML metrics script, cleanup (#14587) * implement APM-120 (#14677) * reintroduce --cluster.index-create-timeout for testing (#14678) we want the timeout to be configurable for arangosync testing. * add missing "." to metric help text :thinking_face: * documentation/swagger-2021-08-24 (#14682) * Improve description of PUT /_api/collection/{coll}/properties Add missing properties, formatting * Document cacheEnabled property for collections * Add maxNodesPerCallstack property to POST /_api/cursor (3.9) * Fix build error * Protocol specific metrics (#14674) * fix potential issue during cluster index creation (#14692) * Docs: Correct database and user API statements (BTS-429) (#14617) * Correct database and user API statements * Update Documentation/DocuBlocks/Rest/Database/get_api_database_new.md Co-authored-by: Vadim Kondratyev <vadim@arangodb.com> * Feature/remove shared ptrs from analyzers (#14694) * update iresearch * get rid of shared ptrs * guidelines fix * fix build * fix build * moar uniques * fix text cmake * fix build * fix build * fix storreFunc execution * fix sharing typed analyzer * fix tests * Feature/minor cleanup (#14661) * TRI_ASSERT Log Stream (#14676) * properly renamed test * Update arangosync to 2.6.0 * Lower priority of AQL lanes (#14695) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * add a test for disabled statistics (#14704) * Update ArangoDB Starter to 0.15.2-preview-1 * Analyzers UI (#14599) * React-specific rules. * Analyzers view. * Modal component for React. * Analyzer delete functional, +notifications. * Stable render of modal children, +AddAnalyzer form stub. * Fixed broken modal re-open. * Delimiter form ready. * All forms ready. * Removed 'Tree' mode. * Analyzer create functional. * Fixed stopwords/stopwordsPath mixup. * 'Create Analyzer' form schema validation. * Added missing fields to Text and N-Gram analyzer forms. * Added support for copying existing analyzer to form state. * Implemented view analyzer details. * UX improvements. As suggested in #14599. * Fixed analyzer selection. * Added UI for AQL and GeoJSON analyzers. * Added UI for GeoPoint analyzer. * Improved validation, +dispatcher to manage state, +form cache. * Changed button styles to match theme. +fixed minor bug in form field setter +error div spacing fix. * Removed 'pointer' cursor on text field labels. * Added help links to locale and delimiter inputs. * Added help text to delimiter field. * Fix bug that caused crash in case of pre-selected analyzer being deleted. * Fixed parsing and UI for latitude/longitude elements. * Reusable form and grid components based on Pure.css. * View mode now provides both JSON and (disabled) form views. * Using relative field paths to support embeddable forms. * Normalized accent input, +made all inputs location agnostic. +Renamed OptionsInput.tsx to GeoOptionsInput.tsx. * Pipeline Analyzer form functional. * Switched to simple text display for code view. * Use text cursor for code view mode. * Added UIs for Stopwords, Collation and Segmentation Analyzers. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Fixed DB base URL evaluation. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Switched to Pure.css-based grid components. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Allow rw access when server is running in non-authenticated mode. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Fixed radio button rendering. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Minor UI improvements. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Fixed modal height issues, +fixed JSON form double scrollbar. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Maximized modal height for view mode. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Minor UI improvements. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Fixed null values for blank numeric inputs. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * UI improvements. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Slightly improved responsive grid. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Reusing FormState as action button prop. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Stricter type restrictions. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Rebuild UI * Update CHANGELOG Co-authored-by: Vadim Kondratyev <vadim@arangodb.com> * Fix a rare shutdown race in RocksDBShaCalculatorThread (#14708) * Fix a rare shutdown race in RocksDBShaCalculatorThread * added assertion as suggested * Add some arangosearch tests (#14664) * add more tests for invetories * update iresearch from upstream * wip * remove unused variable * update iresearch from upstream * update iresearch from upstream * fix compilation * update iresearch from upstream * backport from upstream * add test 10000 for concurrent access to the typed analyzer (#14714) * add test for concurrent access to the typed analyzer inside FieldIterator * Update CHANGELOG * Update CHANGELOG * fix build * make iterator usage safer after intermediate commits (#14346) Co-authored-by: mpoeter <manuel@arangodb.com> * Aardvark: Add missing word in tooltip * Bug fix/search 238 late materialization with constrained heap (#14722) * add test for view case * find a better place for sort * fix formatting * add index case test * moar tests * temporary relaxed assertion * Fix for memory leaks (#14727) * possible asan fix * some change + changelog * Feature/arangosearch link version (#14717) * backport changes from iresearch upstream * use frozen maps * cleanup * add request context for views * wip * wip * add some tests * fix properties deserialization for arangosearch view on coordinator * adjust tests * wip * more tests * more tests * adjust tests * wip * wip * fix tests * Update ArangoDB Starter to 0.15.2 * noexcept requirement ScopeGuard (#14713) * fix for old clang (#14733) * prototype for forceOneShardAttributeValue (#14701) Co-authored-by: Michael Hackstein <michael@arangodb.com> Co-authored-by: Heiko Kernbach <heiko@arangodb.com> * deduplicated TestAnalyzer and TestAttribute (#14737) * disable RTTI for snappy compilation (#14747) * disable RTTI for snappy compilation this restores the state of things before commit 573f7eb * Fix cluster-internal network protocol to HTTP/1 (#14749) * allow for long supervision job runtimes (#14741) * allow for long supervision job runtimes * integration tests * cleanoutserver integration tests * ReplicatedLog 2.0.1 Follow up PR (#14728) * Feature/hybrid smart graph (#14602) * ZKD Indexes (#13650) * Feature/search 213 optimize levenshtein startswith (#14744) * group conjunction nodes * wip * tests * tests * tests * moar tests * add option to explicitly block merging * moar corner cases * empty case optimization * optimization * cleanup * fix startsWith boost * cleanup * wip * wip * comments * add node serialization tests * Update arangod/IResearch/IResearchFilterFactory.cpp Co-authored-by: Andrey Abramov <andrey@arangodb.com> * adress review comments * address review comments * add js test * adress review comments * Update CHANGELOG * None -> NONE renaming Co-authored-by: Andrey Abramov <andrey@arangodb.com> * Fixes for Analyzers Web UI (#14739) * Fixed option label. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Removed placeholders. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Removed duplicate assignment. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Fixed modal body height calculation. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Removed debug statement. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Disable create button when validation errors exist. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Validation for the name field. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Label change (suggested by @Dronplane). Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Remove validation errors when copying state from existing analyzer. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Improved form elements layout. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Restricted resize option on textarea. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Type-specific help link on analyzer type dropdown. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Moved configuration controls to header dropdown. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Rebuild UI * Validation triggered on load and copy (in addition to edit). Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Ensure help icon show inline in pipeline form. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Validation triggered on load and copy (in addition to edit). Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Custom message for discriminator error. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Rebuild UI Co-authored-by: Vadim Kondratyev <vadim@arangodb.com> * Fix: truncate must not trigger intermediate commits in streaming trx. (#14759) * Fix: truncate must not trigger intermediate commits in streaming trx. * add CHANGELOG entry Co-authored-by: mpoeter <manuel@manuel-poeter.at> * Allow startup of arangod with an existing database (#14760) directory that was missing the ZkdIndex column family. * deprecate several extra arangobench testcases (#14756) * Feature/add write pipe func (#14736) * attempt to first uninstall the old service on silent upgrade as well, so the new one can be installed afterwards without problems. * fix syntax * add write pipe function * remove functions * fix return type * add V8 wrappers for write pipe and close pipe * Update js/common/bootstrap/modules/fs.js Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Update lib/Basics/FileUtils.cpp Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Update lib/Basics/process-utils.cpp Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Update lib/Basics/process-utils.cpp Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Update lib/V8/v8-utils.cpp Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Update lib/V8/v8-utils.cpp Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Update lib/V8/v8-utils.cpp Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Update lib/V8/v8-utils.cpp Co-authored-by: Jan <jsteemann@users.noreply.github.com> * add pipe through test * add pipe through test * add pipe through test * Fix stdin/out forwarding on windows * add nullpointer check * revert accidantial commit * add error handling * wintendo linebreaks Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: mpoeter <manuel@arangodb.com> * Feature/apm 70 (#14748) Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: jsteemann <jsteemann@users.noreply.github.com> * micro-optimize RocksDBComparator (#14758) this is a micro-optimization for the code in RocksDBComparator. it may or may not have an impact on performance. performance tests will show. * ensure Query is created via shared_ptr (#14755) * ensure Query is created via shared_ptr This change makes sure that all instances of `Query` and `ClusterQuery` are wrapped into `std::shared_ptr`s upon creation. The constructors of both classes are now protected, meaning it is impossible to create `Query` or `ClusterQuery` instance on the stack from the outside. The only remaining way to create a `Query` or `ClusterQuery` instance is to call the classes' static `create` factory method, which will return a `Query` or `ClusterQuery` object wrapped in a shared_ptr. `Query` is now also derived from `std::enable_shared_from_this<Query>`, meaning we can capture a query instance easily via calling `shared_from_this()` later. Apart from that, nothing is changed yet, so this PR does not yet solve any problem. However, we want to capture shared_ptr-copies of `Query` in callbacks and such, instead of capturing `SharedQueryState`. This should have the advantage that the Query destructor will not be invoked until all callbacks that have references to the query are finished. * fix use-after-move * simplification * fix more use-after-moves * fix use-after-move * workaround for assertion failure (#14711) * workaround for assertion failure * added WAL printing helper function * fix function name in test * update PR * Update OpenSSL to 1.1.1l and OpenLDAP to 2.4.59 (#14768) * fix example * Fixed issue #14720 (#14773) * Fixed issue #14720: Bulk import ignores onDuplicate in 3.8.0. The "onDuplicate" attribute was ignored by the `/_api/import` REST API when not specifying the "type" URL parameter. * Bug fix/fix active failover foxx failover (#14754) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Fix windows unicode issues (#14757) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * properly detect MacOS (#14771) * fix UB in DistributeExecutor (#14774) * fix UB in DistributeExecutor * remove comment * Reduce nr of combinations and runtime of nightly chaos load tests. (#14777) * Adapt scheduler to support bounded and unbounded queue operations. (#14763) Co-authored-by: jsteemann <jsteemann@users.noreply.github.com> * output database directory of instance for better reference (#14783) * docs: fix github docs link (#14787) The `https://help.github.com/send-pull-requests/` is not active anymore, it's better ti use this one `https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork` and event is more suitable for this particular case. * fix typo in URL * Avoid acquisition of recursive read lock on server shutdown (#14792) * fix logId check (#14793) * Add `--datatype` option to arangoimport (#14761) * Add `--datatype` option to arangoimport * Add `--datatype` startup option to arangoimport, in order to hard-code the datatype for certain attributes in the CSV/TSV import. For example, given the following input file: key,price,weight,fk 123456,200,5,585852 864924,120,10,9998242 9949,70,11.5,499494 6939926,2130,5,96962612 When invoking arangoimport with the startup options --datatype key=string --datatype price=number --datatype weight=number --datatype fk=string it will turn the numeric-looking values in "key" into strings (so that they can be used in the `_key` attribute), but treat the attributes "price" and "weight" as numbers. The values in attribute "fk" finally will be treated as strings again (potentially because they are used for linking to other "_key" values). * address review comments * Update arangosh/Import/ImportFeature.cpp Co-authored-by: Simran <Simran-B@users.noreply.github.com> * Update arangosh/Import/ImportFeature.cpp Co-authored-by: Simran <Simran-B@users.noreply.github.com> * Update CHANGELOG Co-authored-by: Simran <Simran-B@users.noreply.github.com> * Add test for --datatype precedence over --convert Co-authored-by: Simran <Simran-B@users.noreply.github.com> Co-authored-by: Simran Spiller <simran@arangodb.com> * Fixed BTS-562 (#14800) * make AQL modification operations blocking again (#14795) * prevent stealing of values from Aql const registers (#14798) * Feature/apm 60 (#14700) * Remove sendRequestRetry in health API to contact agents. (#14785) * add REST API endpoint GET /_admin/debug/failat/all (#14687) * Stabilize Hybrid Smart Graph Test [EE only] (#14809) * dead code removal and cleanup (#14803) * Hide help text fragment about VST connection strings (#14812) in client tools that do not support VST. * Make all synchronous transaction methods set skipScheduler for network requests (#14810) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Fix BTS-548 array index wrong optimization (#14779) * Fix attributesEqual for update/replace array index changes. * CHANGELOG. * Add test. * More tests. * jslint. * APM-164: Add basic overload control to arangod. (#14796) Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: Kaveh Vahedipour <kaveh@arangodb.com> * add more documentation about how tests work (#14804) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * fixed TRI_ASSERT warnings (#14789) * fixed TRI_ASSERT warnings * fixed TRI_ASSERT warnings * fixed TRI_ASSERT warnings Co-authored-by: Vadim Kondratyev <vadim@arangodb.com> * Feature/iresearch update (#14823) * Fix crash in optimizer rule remove-collect-variables (#14824) * enterprise license support (#14753) * steps * devel merge * devel merge * add feature * added expiry metric * change log update * serverstate readonly modes * repaired tests * mock framework to embrace licensefeatrue * Update lib/Basics/errors.dat Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Update lib/Basics/errors.dat Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Update scripts/startLocalCluster.sh Co-authored-by: Jan <jsteemann@users.noreply.github.com> * metric docs * jan comments * Update CHANGELOG Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Node behaviour fixed for toBuilder and showHidden true * Node behaviour fixed for toBuilder and showHidden true * review * review * shell features * .agency mode * metric naming * correct counting of raft index * read only visibility * Update js/client/modules/@arangodb/testsuites/license.js Co-authored-by: Jan <jsteemann@users.noreply.github.com> * promtool * promtool * arangosh cleanup * iresearch tests fixed * repair user manager tests * test link ambiguity of cosmic black matter dientangled * overlapping namespaces and Step class fixed * fixed last persistent error * break non failure_test builds * Update CHANGELOG Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: Vadim <vadim@arangodb.com> * Update CHANGELOG * Fix memory leaks in replicated log tests (#14808) * fixed issue #14819 (#14832) * fixed issue #14819 * updated CHANGELOG * Update CHANGELOG Co-authored-by: Vadim <vadim@arangodb.com> * Feature/apm 121 (#14817) * Added indexHint option for UPSERT and test * attempt to first uninstall the old service on silent upgrade as well (#14731) * attempt to first uninstall the old service on silent upgrade as well, so the new one can be installed afterwards without problems. * fix syntax * fix non-ui hooks * fix silent upgrade process * fix syntax * skip expected error sitiuation from user interaction * forward package vendor * fix installed icon path * Update CHANGELOG * Update CHANGELOG * Update CHANGELOG Co-authored-by: Vadim Kondratyev <vadim@arangodb.com> * Feature/escape unicode control chars (#14805) * Feature/apm 173 (#14830) * Bug fix/dont start license feature in upgrade (#14838) * fixes BTS-602 by not starting license feature * should not start in upgrade database regime * Update CHANGELOG Co-authored-by: Vadim <vadim@arangodb.com> * DocuBlocks: Remove some direct and indirect MMFiles references (#14842) * willi (#14847) * willi * Update CHANGELOG Co-authored-by: Vadim <vadim@arangodb.com> * Added support for adding ZKD index through Web UI. (#14845) * Bug fix/analyzers UI test automation (#14841) * Stable ids for elements. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Changed filter input id. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Rebuild UI Co-authored-by: Aditya Mukhopadhyay <aditya@arangodb.com> Co-authored-by: Vitaly Pryakhin <vitaly@arangodb.com> * Added label to mark ZKD index as experimental. (#14855) Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Fixing CppCheck warnings. (#14854) * improve usage of `__has_include` (#14851) * improve usage of `__has_include` * Update Mutex.h Co-authored-by: Vadim <vadim@arangodb.com> * properly throw an exception in case an invalid state is encountered (#14849) in TableCache::clear(). * Fix SEARCH-235 - Stored values copying in case of encryption (#14764) * add test * store stored values internally * fix build * wip * wip * add template condition for encrypted stored values * fix build * fix tests building * fix engine check * switch to pre-allocated vector * add cluster test * wip * wip * fix missing cleanup * wip * wip * fix reallocations * fix mac build * cleanup * moar cleanup * adress review comments * adress review comments * Micro-optimization for ArangoSearch executor (#14862) * avoid extra copies * fix compilation * cleanup * address compilation issues * LCI was not properly deserialized and thus the coordinator did not display the forwarded LogStatus correctly. (#14861) * Update AqlItemBlock.h * [R2] Remove Dead WaitForQueue Code (#14858) * Remove code that is very compilcated but should never run. Instead just assert. * Fixing logIds. * Capture immutable fields during view creation through web UI. (#14726) * Temp commit before switching to other work (build broken). Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * All immutable view params in UI. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Fixed table input validation. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Removed whitespace-only diffs. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Converted enum text inputs to dropdowns. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Removed whitespace-only diffs. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Removed debug statement. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com> * Apply suggestions from code review Co-authored-by: Heiko <hkernbach@users.noreply.github.com> * Rebuild UI * Bug fix/views web UI part 2 (#14848) * modalView supports now multiple advanced sections, added two m ore accordion containers to arangosearch creation window * remove console log, add possibility to skip label rendering * no labels for search advanced sections * fix styling of a table inside of a modal accordion * move add row button into thead * preperation for switch row btns * more work on UI refactorting related to views - this COMMIT eventually must be removed * Rebuild UI * Update CHANGELOG * Apply suggestions from code review Co-authored-by: Heiko <hkernbach@users.noreply.github.com> * Rebuild UI Co-authored-by: Heiko <hkernbach@users.noreply.github.com> Co-authored-by: Vadim Kondratyev <vadim@arangodb.com> Co-authored-by: Heiko Kernbach <heiko@arangodb.com> * ARM support update: 05.10.2021 Co-authored-by: Max Neunhöffer <max@arangodb.com> Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: Manuel Pöter <manuel.poeter@leanfive.com> Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com> Co-authored-by: Alexey Bakharew <alex.bakharew@gmail.com> Co-authored-by: Michael Hackstein <michael@arangodb.com> Co-authored-by: Heiko <hkernbach@users.noreply.github.com> Co-authored-by: mpoeter <manuel@arangodb.com> Co-authored-by: Simran <Simran-B@users.noreply.github.com> Co-authored-by: Vitaly Pryakhin <vitaly@arangodb.com> Co-authored-by: Lars Maier <lars@arangodb.com> Co-authored-by: Tobias Gödderz <tobias@arangodb.com> Co-authored-by: Frank Celler <392005+fceller@users.noreply.github.com> Co-authored-by: Kaveh Vahedipour <kaveh@arangodb.com> Co-authored-by: Alan Plum <alan@foss-haas.de> Co-authored-by: Aditya Mukhopadhyay <webmaster@adityamukho.com> Co-authored-by: cpjulia <juliamagoo@gmail.com> Co-authored-by: gnusi <gnusi@arangodb.com> Co-authored-by: Andreas Jurdak <56896586+ajurdak@users.noreply.github.com> Co-authored-by: Andreas Jurdak <andreas@jurdak.at> Co-authored-by: Andrey Abramov <andrey@arangodb.com> Co-authored-by: Simran Spiller <simran@arangodb.com> Co-authored-by: Heiko Kernbach <heiko@arangodb.com> Co-authored-by: mpoeter <manuel@manuel-poeter.at> Co-authored-by: Wilfried Goesgens <willi@arangodb.com> Co-authored-by: Boris Popovschi <zyqsempai@mail.ru> Co-authored-by: Aditya Mukhopadhyay <aditya@arangodb.com> Co-authored-by: root <root@ip-172-31-47-116.eu-central-1.compute.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Reduce the amount of macros for exceptions.
Should be merged after #14486
Backports:
Testing & Verification