8000 ui - edges _from and _to attributes finally editable by hkernbach · Pull Request #12039 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

ui - edges _from and _to attributes finally editable #12039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 7, 2020
Merged

ui - edges _from and _to attributes finally editable #12039

merged 9 commits into from
Jul 7, 2020

Conversation

hkernbach
Copy link
Member

Scope & Purpose

The _from and _to attributes of edges are now finally also editable from within the ui.

  • Strictly new functionality
    Will create backports for all supported versions as well.

Related Information

Testing & Verification

This change is a trivial rework / code cleanup without any test coverage.

Preview:
image

@hkernbach hkernbach added 1 Feature 3 UI ArangoDB Web Interface (frontend/Aardvark) labels Jun 29, 2020
@hkernbach hke 8000 rnbach added this to the devel milestone Jun 29, 2020
@hkernbach hkernbach requested a review from KVS85 June 29, 2020 16:07
This was referenced Jun 29, 2020
Merged
Merged
Merged
@hkernbach

This comment has been minimized.

Sign in to view
@hkernbach
Copy link
Member Author

http://jenkins01:8080/view/PR/job/arangodb-matrix-pr/10746/

KVS85
KVS85 requested changes Jun 29, 2020
View reviewed changes
Copy link
Contributor
@KVS85 KVS85 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in collections view but doesn't work during node edit in Graph Viewer (_admin/aardvark/index.html#graph/<NAME>):
image

@hkernbach
Copy link
Member Author

@KVS85 removed from embedded doc editor in the GraphViewer.

@hkernbach hkernbach requested a review from KVS85 June 30, 2020 07:45
@jsteemann jsteemann merged commit 8c3b44d into devel Jul 7, 2020
@jsteemann jsteemann deleted the feature/ui-editable-edges branch July 7, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVS85 KVS85 Awaiting requested review from KVS85

Assignees

@hkernbach hkernbach

Labels
1 Feature 3 UI ArangoDB Web Interface (frontend/Aardvark)
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
3 participants
@hkernbach @KVS85 @jsteemann
0