8000 Feature/improve registerplanning reduce depth by goedderz · Pull Request #11603 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Feature/improve registerplanning reduce depth #11603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 18, 2020
Merged

Feature/improve registerplanning reduce depth #11603

merged 10 commits into from
May 18, 2020

Conversation

goedderz
Copy link
Member
@goedderz goedderz commented May 14, 2020 •
edited
Loading

Scope & Purpose

Reduces the number of registers (the AqlItemBlock width) after a spliced subquery to its previous size. It's simple, but possibly significant improvement to the register planning.

Testing & Verification

This PR adds tests that were used to verify all changes:

  • Added a new C++ Unit Test

@goedderz goedderz added the 9 WIP label May 14, 2020
@goedderz
Copy link
Member Author
goedderz 8000 commented May 14, 2020

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9940/

@goedderz goedderz marked this pull request as ready for review May 14, 2020 13:12
@goedderz
Copy link
Member Author
goedderz commented May 14, 2020 •
edited
Loading

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9944/
http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr-linux/11721/

mchacki
mchacki approved these changes May 14, 2020
View reviewed changes
Copy link
Member
@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Simran-B Simran-B mentioned this pull request May 14, 2020
Closed
@goedderz
Copy link
Member Author

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9985/

@goedderz
Copy link
Member Author
9CCC goedderz commented May 18, 2020

image

@jsteemann jsteemann merged commit 4983aea into devel May 18, 2020
@jsteemann jsteemann deleted the feature/improve-registerplanning-reduce-depth branch May 18, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchacki mchacki mchacki approved these changes

@maierlars maierlars maierlars approved these changes

Assignees

@goedderz goedderz

@maierlars maierlars

Labels
9 Waiting for Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goedderz @mchacki @maierlars @jsteemann
0