10000 Fix shell-compaction-mmfiles-noncluster-timecritical and ungreylist by markuspf · Pull Request #10616 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Fix shell-compaction-mmfiles-noncluster-timecritical and ungreylist #10616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and 10000 privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

markuspf
Copy link
Contributor
@markuspf markuspf commented Dec 3, 2019

This test ran throughout the night with no failure. Jenkins for verification: https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/7527/ see also https://github.com/arangodb/planning/issues/4682

@markuspf
Copy link
Contributor Author
markuspf commented Dec 5, 2019

Jenkins run to validate mergeability

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/7563/

Copy link
Contributor
@KVS85 KVS85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shell-compaction-mmfiles-noncluster-timecritical-grey.js -> tests/js/server/shell/shell-compaction-mmfiles-noncluster.js to be executed in PRs.

@markuspf
Copy link
Contributor Author
markuspf commented Dec 5, 2019

Markus Pfeiffer added 2 commits December 11, 2019 08:59
Wait for a reasonable amount of time for compactions to occur in the relevant
tests, not just wait for about 7 seconds and hope that it did.
@markuspf
Copy link
Contributor Author

I updated the test now to not just wait for 7 seconds and hope that a compaction occurred, but to watch the collection's figures to see whether data was actually moved around.

@markuspf markuspf changed the title Ungreylist shell-compaction-mmfiles-noncluster-timecritical Fix shell-compaction-mmfiles-noncluster-timecritical and ungreylist Dec 12, 2019
Copy link
Contributor Author

@markuspf markuspf requested review from jsteemann and KVS85 December 12, 2019 12:32
@markuspf
Copy link
Contributor Author

Jenkins is blue

@jsteemann jsteemann merged commit 705fab3 into devel Dec 16, 2019
@jsteemann jsteemann deleted the feature/shell-compaction-mmfiles-noncluster-timecritical branch December 16, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0