8000 [3.5] Fix document search (Ctrl+F/Cmd+F) by pluma · Pull Request #10215 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

[3.5] Fix document search (Ctrl+F/Cmd+F) #10215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2019
Merged

[3.5] Fix document search (Ctrl+F/Cmd+F) #10215

merged 3 commits into from
Oct 11, 2019

Conversation

pluma
Copy link
Contributor
@pluma pluma commented Oct 10, 2019

Scope & Purpose

This fixes a longstanding regression in 3.x that broke search in the document editor in code view. The browser search doesn't work in ACE and the JSON Editor uses a searchbox extension that for some reason needs to be loaded dynamically via a hardcoded path. This PR simply maps that path to the file it's looking for.

  • Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

Related Information

I've reported this issue internally before.

Testing & Verification

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Added a Changelog Entry (referencing the corresponding public or internal issue number)
  • Added entry to Release Notes

@pluma pluma added 1 Bug 3 UI ArangoDB Web Interface (frontend/Aardvark) labels Oct 10, 2019
@pluma pluma added this to the 3.5 milestone Oct 10, 2019
@pluma pluma requested a review from hkernbach October 10, 2019 09:45
@pluma pluma modified the milestones: 3.5, 3.5.2 Oct 10, 2019
hkernbach
hkernbach approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member
@hkernbach hkernbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@pluma could you also create a PR for devel pls?

@pluma pluma mentioned this pull request Oct 10, 2019
Merged
@pluma pluma changed the title Fix document search (Ctrl+F/Cmd+F) [3.5] Fix document search (Ctrl+F/Cmd+F) Oct 10, 2019
@pluma
Copy link
Contributor Author
pluma commented Oct 10, 2019

Devel PR created.

@hkernbach hkernbach mentioned this pull request Oct 11, 2019
Merged
@KVS85 KVS85 merged commit e4e53b9 into 3.5 Oct 11, 2019
@KVS85 KVS85 deleted the bug-fix/aardvark-document-search branch October 11, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkernbach hkernbach hkernbach approved these changes

Assignees
No one assigned
Labels
1 Bug 3 UI ArangoDB Web Interface (frontend/Aardvark) 9 Ready to Merge
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@pluma @hkernbach @KVS85
0