8000 fix logId check (#14793) · arangodb/arangodb@a293372 · GitHub
[go: up one dir, main page]

Skip to content

Commit a293372

Browse files
authored
fix logId check (#14793)
1 parent 0543b00 commit a293372

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

arangod/Pregel/Conductor.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@ using namespace arangodb;
5757
using namespace arangodb::pregel;
5858
using namespace arangodb::basics;
5959

60-
#define LOG_PREGEL(id, level) LOG_TOPIC(id, level, Logger::PREGEL) << "[job " << _executionNumber << "] "
60+
#define LOG_PREGEL(logId, level) \
61+
LOG_TOPIC(logId, level, Logger::PREGEL) \
62+
<< "[job " << _executionNumber << "] "
6163

6264
const char* arangodb::pregel::ExecutionStateNames[8] = {
6365
"none", "running", "storing", "done",

arangod/Pregel/GraphStore.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@
6161
using namespace arangodb;
6262
using namespace arangodb::pregel;
6363

64-
#define LOG_PREGEL(id, level) LOG_TOPIC(id, level, Logger::PREGEL) << "[job " << _executionNumber << "] "
64+
#define LOG_PREGEL(logId, level) \
65+
LOG_TOPIC(logId, level, Logger::PREGEL) \
66+
<< "[job " << _executionNumber << "] "
6567

6668
namespace {
6769
static constexpr size_t minStringChunkSize = 16 * 1024 * sizeof(char);
@@ -302,7 +304,7 @@ std::unique_ptr<TypedBuffer<M>> createBuffer(WorkerConfig const& config, size_t
302304
template <typename V, typename E>
303305
void GraphStore<V, E>::loadVertices(ShardID const& vertexShard,
304306
std::vector<ShardID> const& edgeShards) {
305-
LOG_PREGEL("24837", DEBUG)
307+
LOG_PREGEL("24838", DEBUG)
306308
<< "Loading from vertex shard " << vertexShard << ", edge shards: " << edgeShards;
307309

308310
transaction::Options trxOpts;

arangod/Pregel/Worker.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ using namespace arangodb;
4141
using namespace arangodb::basics;
4242
using namespace arangodb::pregel;
4343

44-
#define LOG_PREGEL(id, level) LOG_TOPIC(id, level, Logger::PREGEL) << "[job " << _config.executionNumber() << "] "
44+
#define LOG_PREGEL(logId, level) \
45+
LOG_TOPIC(logId, level, Logger::PREGEL) \
46+
<< "[job " << _config.executionNumber() << "] "
4547

4648
#define MY_READ_LOCKER(obj, lock) \
4749
ReadLocker<ReadWriteLock> obj(&lock, arangodb::basics::LockerType::BLOCKING, \

utils/checkLogIds.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def is_good(status):
1818
return status in (Status.OK, Status.OK_REPLACED)
1919

2020
import re
21-
g_log_topic_pattern = re.compile(r'(?P<macro>LOG_(TOPIC(_IF)?|TRX|CTX(_IF)?|QUERY))\((?P<param>[^),]*),(?P<rest>.*)')
21+
g_log_topic_pattern = re.compile(r'(?P<macro>LOG_(TOPIC(_IF)?|TRX|CTX(_IF)?|QUERY|PREGEL))\((?P<param>[^),]*),(?P<rest>.*)')
2222

2323
import hashlib
2424
g_hash_algorithm = hashlib.md5()

0 commit comments

Comments
 (0)
0