Bug fix 3.2/agency loop wrong credentials (#7073)

hkernbach · mchacki · commit 4ef6911601c9 · 2018-10-25T14:17:44.000+02:00
* arangod now exits when used wrong credentials during the startup process

* changelog
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,6 +1,9 @@
 v3.2.17 (2018-10-24)
 --------------------
 
+* in a cluster environment, the arangod process now exits if wrong credentials
+  are used during the startup process.
+
 * upgraded arangodb starter version to 0.13.7
 
 * when returning memory to the OS, use the same memory protection flags as 
diff --git a/arangod/Agency/AgencyComm.cpp b/arangod/Agency/AgencyComm.cpp
@@ -1198,6 +1198,12 @@ bool AgencyComm::ensureStructureInitialized() {
         LOG_TOPIC(TRACE, Logger::AGENCYCOMM) << "Found an initialized agency";
         break;
       }
+    } else {
+      if (result.httpCode() == 401) {
+        // unauthorized
+        LOG_TOPIC(FATAL, Logger::STARTUP) << "Unauthorized. Wrong credentials.";
+        FATAL_ERROR_EXIT();
+      }
     }
 
     LOG_TOPIC(TRACE, Logger::AGENCYCOMM)

Original file line number	Diff line number	Diff line change
`@@ -1198,6 +1198,12 @@ bool AgencyComm::ensureStructureInitialized() {`
`1198`	`1198`	`LOG_TOPIC(TRACE, Logger::AGENCYCOMM) << "Found an initialized agency";`
`1199`	`1199`	`break;`
`1200`	`1200`	`}`
	`1201`	`+ } else {`
	`1202`	`+ if (result.httpCode() == 401) {`
	`1203`	`+ // unauthorized`
	`1204`	`+ LOG_TOPIC(FATAL, Logger::STARTUP) << "Unauthorized. Wrong credentials.";`
	`1205`	`+ FATAL_ERROR_EXIT();`
	`1206`	`+ }`
`1201`	`1207`	`}`
`1202`	`1208`
`1203`	`1209`	`LOG_TOPIC(TRACE, Logger::AGENCYCOMM)`