"run with --log v8=debug" to see the stacktraces of logged error messages (#10373)

dothebart · neunhoef · commit 396ceebf0dc0 · 2019-11-13T10:24:10.000+01:00
diff --git a/lib/V8/v8-utils.cpp b/lib/V8/v8-utils.cpp
@@ -5113,6 +5113,15 @@ void TRI_LogV8Exception(v8::Isolate* isolate, v8::TryCatch* tryCatch) {
 
       LOG_TOPIC("cb0bd", ERR, arangodb::Logger::FIXME) << "!" << l;
     }
+    auto stacktraceV8 =
+      tryCatch->StackTrace(TRI_IGETC).FromMaybe(v8::Local<v8::Value>());
+    TRI_Utf8ValueNFC stacktrace(isolate, stacktraceV8);
+
+    if (*stacktrace && stacktrace.length() > 0) {
+      LOG_TOPIC("cb0bf", DEBUG, arangodb::Logger::V8) << "!" <<
+        "stacktrace: " + std::string(*stacktrace) + "\n";
+    }
+
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5113,6 +5113,15 @@ void TRI_LogV8Exception(v8::Isolate* isolate, v8::TryCatch* tryCatch) {`
`5113`	`5113`
`5114`	`5114`	`LOG_TOPIC("cb0bd", ERR, arangodb::Logger::FIXME) << "!" << l;`
`5115`	`5115`	`}`
	`5116`	`+ auto stacktraceV8 =`
	`5117`	`+ tryCatch->StackTrace(TRI_IGETC).FromMaybe(v8::Local<v8::Value>());`
	`5118`	`+ TRI_Utf8ValueNFC stacktrace(isolate, stacktraceV8);`
	`5119`	`+`
	`5120`	`+ if (*stacktrace && stacktrace.length() > 0) {`
	`5121`	`+ LOG_TOPIC("cb0bf", DEBUG, arangodb::Logger::V8) << "!" <<`
	`5122`	`+ "stacktrace: " + std::string(*stacktrace) + "\n";`
	`5123`	`+ }`
	`5124`	`+`
`5116`	`5125`	`}`
`5117`	`5126`	`}`
`5118`	`5127`