arangodb
diff --git a/‎arangod/RocksDBEngine/Methods/RocksDBTrxBaseMethods.cpp‎
Lines changed: 0 additions & 13 deletions b/‎arangod/RocksDBEngine/Methods/RocksDBTrxBaseMethods.cpp‎
Lines changed: 0 additions & 13 deletions
diff --git a/‎arangod/RocksDBEngine/RocksDBEngine.cpp‎
Lines changed: 0 additions & 13 deletions b/‎arangod/RocksDBEngine/RocksDBEngine.cpp‎
Lines changed: 0 additions & 13 deletions
diff --git a/‎arangod/RocksDBEngine/RocksDBSyncThread.cpp‎
Lines changed: 0 additions & 2 deletions b/‎arangod/RocksDBEngine/RocksDBSyncThread.cpp‎
Lines changed: 0 additions & 2 deletions
@@ -348,17 +348,6 @@ arangodb::Result RocksDBTrxBaseMethods::doCommit() {
   // if we fail during commit, make sure we remove blockers, etc.
   auto cleanupCollTrx = scopeGuard([this]() { _state->cleanupCollections(); });
 
-#ifdef _WIN32
-  // set wait for sync flag if required
-  // we do this only for Windows here, because all other platforms use the
-  // RocksDB SyncThread to do the syncing
-  if (_state->waitForSync()) {
-    rocksdb::WriteOptions wo;
-    wo.sync = true;
-    _rocksTransaction->SetWriteOptions(wo);
-  }
-#endif
-
   // total number of sequence ID consuming records
   uint64_t numOps = _rocksTransaction->GetNumPuts() +
                     _rocksTransaction->GetNumDeletes() +
@@ -387,7 +376,6 @@ arangodb::Result RocksDBTrxBaseMethods::doCommit() {
   _state->commitCollections(_lastWrittenOperationTick);
   cleanupCollTrx.cancel();
 
-#ifndef _WIN32
   // wait for sync if required, for all other platforms but Windows
   if (_state->waitForSync()) {
     auto& selector = _state->vocbase().server().getFeature<EngineSelectorFeature>();
@@ -402,7 +390,6 @@ arangodb::Result RocksDBTrxBaseMethods::doCommit() {
       return RocksDBSyncThread::sync(engine.db()->GetBaseDB());
     }
   }
-#endif
 
   return Result();
 }
@@ -184,12 +184,7 @@ RocksDBEngine::RocksDBEngine(application_features::ApplicationServer& server)
       _pruneWaitTimeInitial(180.0),
       _maxWalArchiveSizeLimit(0),
       _releasedTick(0),
-#ifdef _WIN32
-      // background syncing is not supported on Windows
-      _syncInterval(0),
-#else
       _syncInterval(100),
-#endif
       _syncDelayThreshold(5000),
       _requiredDiskFreePercentage(0.01),
       _requiredDiskFreeBytes(16 * 1024 * 1024),
@@ -410,14 +405,6 @@ void RocksDBEngine::validateOptions(std::shared_ptr<options::ProgramOptions> opt
     }
   }
 
-#ifdef _WIN32
-  if (_syncInterval > 0) {
-    LOG_TOPIC("68301", WARN, arangodb::Logger::CONFIG)
-        << "automatic syncing of RocksDB WAL via background thread is not "
-        << " supported on this platform";
-  }
-#endif
-
   if (_pruneWaitTimeInitial < 10) {
     LOG_TOPIC("a9667", WARN, arangodb::Logger::ENGINES)
         << "consider increasing the value for "
 
@@ -75,7 +75,6 @@ Result RocksDBSyncThread::syncWal() {
 }
 
 Result RocksDBSyncThread::sync(rocksdb::DB* db) {
-#ifndef _WIN32
   // if called on Windows, we would get the following error from RocksDB:
   // > Not implemented: SyncWAL() is not supported for this implementation of
   // WAL file
@@ -85,7 +84,6 @@ Result RocksDBSyncThread::sync(rocksdb::DB* db) {
   if (!status.ok()) {
     return rocksutils::convertStatus(status);
   }
-#endif
   return Result();
 }
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,6 @@ Result RocksDBSyncThread::syncWal() {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`Result RocksDBSyncThread::sync(rocksdb::DB* db) {`
`78`		`-#ifndef _WIN32`
`79`	`78`	`// if called on Windows, we would get the following error from RocksDB:`
`80`	`79`	`// > Not implemented: SyncWAL() is not supported for this implementation of`
`81`	`80`	`// WAL file`
`@@ -85,7 +84,6 @@ Result RocksDBSyncThread::sync(rocksdb::DB* db) {`
`85`	`84`	`if (!status.ok()) {`
`86`	`85`	`return rocksutils::convertStatus(status);`
`87`	`86`	`}`
`88`		`-#endif`
`89`	`87`	`return Result();`
`90`	`88`	`}`
`91`	`89`