apfunk
diff --git a/‎LibGit2Sharp/Core/NativeMethods.cs
Lines changed: 1 addition & 1 deletion b/‎LibGit2Sharp/Core/NativeMethods.cs
Lines changed: 1 addition & 1 deletion
diff --git a/‎LibGit2Sharp/Core/Proxy.cs
Lines changed: 5 additions & 11 deletions b/‎LibGit2Sharp/Core/Proxy.cs
Lines changed: 5 additions & 11 deletions
@@ -182,7 +182,7 @@ internal static extern int git_branch_move(
         [DllImport(libgit2)]
         internal static extern int git_branch_next(
             out ReferenceSafeHandle ref_out,
-            out IntPtr type_out,
+            out GitBranchType type_out,
             BranchIteratorSafeHandle iter);
 
         [DllImport(libgit2)]
 
@@ -147,32 +147,28 @@ public static IEnumerable<Branch> git_branch_iterator(Repository repo, GitBranch
             {
                 BranchIteratorSafeHandle iter_out = null;
 
-                var branches = new List<Branch>();
-
                 try
                 {
                     Ensure.ZeroResult(NativeMethods.git_branch_iterator_new(out iter_out, repo.Handle, branchType));
 
-                    int res = 0;
-
-                    while (res == (int)GitErrorCode.Ok)
+                    while(true)
                     {
                         ReferenceSafeHandle ref_out = null;
                         try
                         {
-                            IntPtr type_out;
-                            res = NativeMethods.git_branch_next(out ref_out, out type_out, iter_out);
+                            GitBranchType type_out;
+                            var res = NativeMethods.git_branch_next(out ref_out, out type_out, iter_out);
 
                             if (res == (int) GitErrorCode.IterOver)
                             {
-                                break;
+                                yield break;
                             }
 
                             Ensure.ZeroResult(res);
 
                             var reference = Reference.BuildFromPtr<Reference>(ref_out, repo);
 
-                            branches.Add(new Branch(repo, reference, reference.CanonicalName));
+                            yield return new Branch(repo, reference, reference.CanonicalName);
                         }
                         finally
                         {
@@ -184,8 +180,6 @@ public static IEnumerable<Branch> git_branch_iterator(Repository repo, GitBranch
                 {
                     iter_out.SafeDispose();
                 }
-
-                return branches;
             }
         }
Original file line number	Diff line number	Diff line change
`@@ -147,32 +147,28 @@ public static IEnumerable<Branch> git_branch_iterator(Repository repo, GitBranch`
`147`	`147`	`{`
`148`	`148`	`BranchIteratorSafeHandle iter_out = null;`
`149`	`149`
`150`		`- var branches = new List<Branch>();`
`151`		`-`
`152`	`150`	`try`
`153`	`151`	`{`
`154`	`152`	`Ensure.ZeroResult(NativeMethods.git_branch_iterator_new(out iter_out, repo.Handle, branchType));`
`155`	`153`
`156`		`- int res = 0;`
`157`		`-`
`158`		`- while (res == (int)GitErrorCode.Ok)`
	`154`	`+ while(true)`
`159`	`155`	`{`
`160`	`156`	`ReferenceSafeHandle ref_out = null;`
`161`	`157`	`try`
`162`	`158`	`{`
`163`		`- IntPtr type_out;`
`164`		`- res = NativeMethods.git_branch_next(out ref_out, out type_out, iter_out);`
	`159`	`+ GitBranchType type_out;`
	`160`	`+ var res = NativeMethods.git_branch_next(out ref_out, out type_out, iter_out);`
`165`	`161`
`166`	`162`	`if (res == (int) GitErrorCode.IterOver)`
`167`	`163`	`{`
`168`		`- break;`
	`164`	`+ yield break;`
`169`	`165`	`}`
`170`	`166`
`171`	`167`	`Ensure.ZeroResult(res);`
`172`	`168`
`173`	`169`	`var reference = Reference.BuildFromPtr<Reference>(ref_out, repo);`
`174`	`170`
`175`		`- branches.Add(new Branch(repo, reference, reference.CanonicalName));`
	`171`	`+ yield return new Branch(repo, reference, reference.CanonicalName);`
`176`	`172`	`}`
`177`	`173`	`finally`
`178`	`174`	`{`
`@@ -184,8 +180,6 @@ public static IEnumerable<Branch> git_branch_iterator(Repository repo, GitBranch`
`184`	`180`	`{`
`185`	`181`	`iter_out.SafeDispose();`
`186`	`182`	`}`
`187`		`-`
`188`		`- return branches;`
`189`	`183`	`}`
`190`	`184`	`}`
`191`	`185`