8000 ci: add substrait feature to linux builds by Michael-J-Ward · Pull Request #720 · apache/datafusion-python · GitHub
[go: up one dir, main page]
Skip to content

ci: add substrait feature to linux builds #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

ci: add substrait feature to linux builds #720

merged 1 commit into from
May 31, 2024

Conversation

Michael-J-Ward
Copy link
Contributor
@Michael-J-Ward Michael-J-Ward commented May 30, 2024 •
edited
Loading

Which issue does this PR close?

Closes #646.

Rationale for this change

These build steps were setting --features protoc, which I think was over-riding the features = ["substrait"] in pyproject.toml

Are there any user-facing changes?

There should not be.

andygrove
andygrove approved these changes May 31, 2024
View reviewed changes
Copy link
Member
@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michael-J-Ward

@andygrove andygrove merged commit ef88921 into apache:main May 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versions >32.0.0 on PyPI have broken substrait support
2 participants
@Michael-J-Ward @andygrove
0