fix(@angular/cli): exit with a non-zero error code when migration fails during ng update

alan-agius4 · alan-agius4 · commit ded7b5c069a1 · 2021-11-24T17:12:13.000+01:00
In some cases, when a migration fails an error is not thrown, instead the `executeMigration` return a `false` value when resolved. With this change, we fix an issue were failed migrations resulted in the process of not terminating with a non-zero error code. (cherry picked from commit b9cd68f)
diff --git a/packages/angular/cli/commands/update-impl.ts b/packages/angular/cli/commands/update-impl.ts
@@ -482,8 +482,9 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {
         }
       }
 
+      let result: boolean;
       if (typeof options.migrateOnly == 'string') {
-        await this.executeMigration(
+        result = await this.executeMigration(
           packageName,
           migrations,
           options.migrateOnly,
@@ -497,7 +498,7 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {
           return 1;
         }
 
-        await this.executeMigrations(
+        result = await this.executeMigrations(
           packageName,
           migrations,
           from,
@@ -506,7 +507,7 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {
         );
       }
 
-      return 1;
+      return result ? 0 : 1;
     }
 
     const requests: {

Original file line number	Diff line number	Diff line change
`@@ -482,8 +482,9 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {`
`482`	`482`	`}`
`483`	`483`	`}`
`484`	`484`
	`485`	`+ let result: boolean;`
`485`	`486`	`if (typeof options.migrateOnly == 'string') {`
`486`		`- await this.executeMigration(`
	`487`	`+ result = await this.executeMigration(`
`487`	`488`	`packageName,`
`488`	`489`	`migrations,`
`489`	`490`	`options.migrateOnly,`
`@@ -497,7 +498,7 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {`
`497`	`498`	`return 1;`
`498`	`499`	`}`
`499`	`500`
`500`		`- await this.executeMigrations(`
	`501`	`+ result = await this.executeMigrations(`
`501`	`502`	`packageName,`
`502`	`503`	`migrations,`
`503`	`504`	`from,`
`@@ -506,7 +507,7 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {`
`506`	`507`	`);`
`507`	`508`	`}`
`508`	`509`
`509`		`- return 1;`
	`510`	`+ return result ? 0 : 1;`
`510`	`511`	`}`
`511`	`512`
`512`	`513`	`const requests: {`