10000 build: update TS to 4.4.3 by rafaelss95 · Pull Request #697 · angular-eslint/angular-eslint · GitHub
[go: up one dir, main page]
Skip to content

build: update TS to 4.4.3 #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

build: update TS to 4.4.3 #697

wants to merge 2 commits into from

Conversation

rafaelss95
Copy link
Member
@rafaelss95 rafaelss95 commented Sep 20, 2021 •
edited
Loading

This updates TS to 4.4.3 so we can use new features 🔥.

@rafaelss95 rafaelss95 mentioned this pull request Sep 20, 2021
Closed
@nx-cloud
Copy link
nx-cloud bot commented Sep 20, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 6c81da2. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node v14.16.1 - nx run-many --target=integration-test --all --withRegistry
#000000 Node v14.16.1 - nx run-many --target=typecheck --all --parallel
#000000 Node v14.16.1 - nx run-many --target=test --all --parallel
#000000 Node v14.16.1 - nx run-many --target=check-configs --all --parallel
#000000 Node v14.16.1 - nx run-many --target=build --all --parallel
#000000 Node v14.16.1 - nx run-many --target=check-rule-docs --all --parallel
#000000 Node v14.16.1 - nx build utils
#000000 Node v12.22.6 - nx run-many --target=test --all --parallel
#000000 Node v12.22.6 - nx run-many --target=build --all --parallel

Sent with 💌 from NxCloud.

@JamesHenry
Copy link
Member

@rafaelss95 We usually choose the TypeScript version based on the version that the currently supported major version of Angular is supporting.

It looks like TS 4.4 has been a tricky one to land for Angular: angular/angular#43281 and it is still not in yet so I think we should hold off for now

@JamesHenry JamesHenry closed this Sep 21, 2021
@rafaelss95 rafaelss95 deleted the build/ts-4.3 branch September 21, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry Awaiting requested review from JamesHenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelss95 @JamesHenry
0