8000 chore: update primary and additional node versions (#952) · angular-eslint/angular-eslint@bd747ba · GitHub
[go: up one dir, main page]
Skip to content

Commit bd747ba

Browse files
JamesHenryJamesHenry
authored
chore: update primary and additional node versions (#952)
1 parent 1ee158a commit bd747ba

File tree

6 files changed

+210
-88
lines changed

6 files changed

+210
-88
lines changed

‎.github/workflows/ci.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,9 @@ jobs:
143143
runs-on: ubuntu-latest
144144
strategy:
145145
matrix:
146-
# Angular CLI explicitly only supports Node version 12 or 14 at the time of writing
147-
node: [12]
146+
# Additionally supported node versions taken from:
147+
# https://gist.github.com/LayZeeDK/c822cc812f75bb07b7c55d07ba2719b3
148+
node: ['^12.20.2', '^14.15.5']
148149
steps:
149150
- name: Set NX_RUN_GROUP based on the output of the create_nx_run_group job
150151
run: echo "NX_RUN_GROUP=${{ needs.create_nx_run_group.outputs.nx_run_group }}" >> $GITHUB_ENV
@@ -158,7 +159,7 @@ jobs:
158159
with:
159160
main-branch-name: master
160161

161-
- uses: actions/setup-node@v2
162+
- uses: actions/setup-node@v3
162163
with:
163164
# The Node.js version to configure
164165
node-version: ${{ matrix.node }}
@@ -221,7 +222,7 @@ jobs:
221222
echo "::set-output name=node_version::$(node --version)"
222223
223224
- name: Apply version resolved by volta to standard Node action make authenticated npm publish easier
224-
uses: actions/setup-node@v2
225+
uses: actions/setup-node@v3
225226
with:
226227
node-version: ${{ steps.yarn-cache-dir-path.outputs.node_version }}
227228
registry-url: https://registry.npmjs.org/

‎package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22
"name": "@angular-eslint/angular-eslint",
33
"private": true,
44
"volta": {
5-
"node": "14.19.0",
6-
"npm": "6.14.16",
7-
"yarn": "1.22.17"
5+
"node": "16.14.2",
6+
"yarn": "1.22.18"
87
},
98
"workspaces": [
109
"packages/*"

‎packages/integration-tests/fixtures/v1123-multi-project-manual-config/.npmrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
# Not having a package-lock makes it much easier to deal with installing
22
# our local packages in a CI environment
33
package-lock=false
4+
# TODO: Upgrade npm fixtures so that --force is no longer needed
5+
force=true

‎packages/integration-tests/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
"typescript": "*"
88
},
99
"devDependencies": {
10-
"verdaccio": "5.5.2"
10+
"verdaccio": "5.8.0"
1111
}
1212
}

‎packages/integration-tests/publish-to-verdaccio.sh

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,32 +31,36 @@ echo ""
3131
# There is no way for us to publish via lerna while our git working directory is not clean,
3232
# which is the case because of our version bump, so manually publish all the relevant packages for now
3333

34+
# For npm v7 and later, an authToken needs to be present in the publish request (even though we don't use it
35+
# for the publishing to verdaccio)
36+
# Source: https://twitter.com/verdaccio_npm/status/1357798427283910660
37+
3438
cd ./packages/builder
35-
npm publish --registry $NPM_REGISTRY
39+
npm publish --registry $NPM_REGISTRY --//localhost:4872/:_authToken fake
3640
cd -
3741

3842
cd ./packages/bundled-angular-compiler
39-
npm publish --registry $NPM_REGISTRY
43+
npm publish --registry $NPM_REGISTRY --//localhost:4872/:_authToken fake
4044
cd -
4145

4246
cd ./packages/eslint-plugin
43-
npm publish --registry $NPM_REGISTRY
47+
npm publish --registry $NPM_REGISTRY --//localhost:4872/:_authToken fake
4448
cd -
4549

4650
cd ./packages/eslint-plugin-template
47-
npm publish --registry $NPM_REGISTRY
51+
npm publish --registry $NPM_REGISTRY --//localhost:4872/:_authToken fake
4852
cd -
4953

5054
cd ./packages/schematics
51-
npm publish --registry $NPM_REGISTRY
55+
npm publish --registry $NPM_REGISTRY --//localhost:4872/:_authToken fake
5256
cd -
5357

5458
cd ./packages/template-parser
55-
npm publish --registry $NPM_REGISTRY
59+
npm publish --registry $NPM_REGISTRY --//localhost:4872/:_authToken fake
5660
cd -
5761

5862
cd ./packages/utils
59-
npm publish --registry $NPM_REGISTRY
63+
npm publish --registry $NPM_REGISTRY --//localhost:4872/:_authToken fake
6064
cd -
6165

6266
echo ""

0 commit comments

Comments
 (0)
0