8000 docs(guide/Migrating from Previous Versions): improve grammar in jque… by graingert · Pull Request #15518 · angular/angular.js · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Migrating from Previous Versions): improve grammar in jque… #15518

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/guide/migration.ngdoc
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ commits for more info.

- **jqLite** is more aligned to jQuery 3, which required the following changes
(see [details](guide/migration#migrate1.5to1.6-ng-misc-jqLite) below):
- Keys passed to `.data()` and `.css()` are now camelCased in the same as jQuery does it.
- Keys passed to `.data()` and `.css()` are now camelCased in the same way as jQuery.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree the original sentence is not ideal, I find the new version ambiguous. It can be interpreted as:

[...] are now camelCased in the same way as jQuery is camelCased

- Setting boolean attributes to empty string no longer removes the attribute.
- Calling `.val()` on a multiple select will always return an array, even if no option is
selected.
Expand Down
0