8000 perf(merge): remove unnecessary wrapping of jqLite element · angular/angular.js@ce6a96b · GitHub
[go: up one dir, main page]

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit ce6a96b

Browse files
committed
perf(merge): remove unnecessary wrapping of jqLite element
Fixes 75292a6#commitcomment-14137538 Closes #13236
1 parent d4b359f commit ce6a96b

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/Angular.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ function baseExtend(dst, objs, deep) {
363363
} else if (src.nodeName) {
364364
dst[key] = src.cloneNode(true);
365365
} else if (isElement(src)) {
366-
dst[key] = jqLite(src).clone();
366+
dst[key] = src.clone();
367367
} else {
368368
if (!isObject(dst[key])) dst[key] = isArray(src) ? [] : {};
369369
baseExtend(dst[key], [src], true);

test/AngularSpec.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -626,8 +626,10 @@ describe('angular', function() {
626626

627627

628628
it('should copy(clone) elements', function() {
629-
var src = { element: document.createElement('div'),
630-
jqObject: jqLite("<p><span>s1</span><span>s2</span></p>").find("span") };
629+
var src = {
630+
element: document.createElement('div'),
631+
jqObject: jqLite('<p><span>s1</span><span>s2</span></p>').find('span')
632+
};
631633
var dst = {};
632634

633635
merge(dst, src);
@@ -638,7 +640,7 @@ describe('angular', function() {
638640
expect(isElement(dst.element)).toBeTruthy();
639641
expect(dst.element.nodeName).toBeDefined(); // i.e it is a DOM element
640642
expect(isElement(dst.jqObject)).toBeTruthy();
641-
expect(dst.jqObject.nodeName).toBeUndefined(dst.jqObject); // i.e it is a jqLite/jquery object
643+
expect(dst.jqObject.nodeName).toBeUndefined(); // i.e it is a jqLite/jQuery object
642644
});
643645
});
644646

0 commit comments

Comments
 (0)
0