refactor(*): move noop functions to angular.noop

ivomju · Narretz · commit 4e30e4a1e3de · 2016-02-29T18:08:52.000+01:00
Closes #14151
diff --git a/src/ng/animate.js b/src/ng/animate.js
@@ -54,7 +54,7 @@ function prepareAnimateOptions(options) {
 }
 
 var $$CoreAnimateJsProvider = function() {
-  this.$get = function() {};
+  this.$get = noop;
 };
 
 // this is prefixed with Core since it conflicts with
diff --git a/src/ng/compile.js b/src/ng/compile.js
@@ -1075,7 +1075,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
    * See also {@link ng.$compileProvider#directive $compileProvider.directive()}.
    */
   this.component = function registerComponent(name, options) {
-    var controller = options.controller || function() {};
+    var controller = options.controller || noop;
 
     function factory($injector) {
       function makeInjectable(fn) {
diff --git a/src/ng/parse.js b/src/ng/parse.js
@@ -1314,7 +1314,7 @@ ASTInterpreter.prototype = {
     forEach(ast.body, function(expression) {
       expressions.push(self.recurse(expression.expression));
     });
-    var fn = ast.body.length === 0 ? function() {} :
+    var fn = ast.body.length === 0 ? noop :
              ast.body.length === 1 ? expressions[0] :
              function(scope, locals) {
                var lastValue;

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ function prepareAnimateOptions(options) {`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`var $$CoreAnimateJsProvider = function() {`
`57`		`- this.$get = function() {};`
	`57`	`+ this.$get = noop;`
`58`	`58`	`};`
`59`	`59`
`60`	`60`	`// this is prefixed with Core since it conflicts with`