8000 build: re-enable material e2e tests · angular/angular-cli@17f9136 · GitHub
[go: up one dir, main page]

Skip to content

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 17f9136

Browse files
crisbetoalan-agius4
authored andcommitted
build: re-enable material e2e tests
The Material tests had to be disabled temporarily during the TS 4.9 update, because the peer dependency range didn't allow for `next` versions. Now that the range was expanded in angular/components#26308, the tests should work again. (cherry picked from commit e2a6776)
1 parent 988ec0c commit 17f9136

File tree

3 files changed

+0
-9
lines changed

3 files changed

+0
-9
lines changed

tests/legacy-cli/e2e/tests/build/material.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ import { isPrereleaseCli, updateJsonFile } from '../../utils/project';
77
const snapshots = require('../../ng-snapshot/package.json');
88

99
export default async function () {
10-
// TODO(crisbeto): temporarily disabled until Material is updated
11-
return;
12-
1310
let tag = (await isPrereleaseCli()) ? '@next' : '';
1411
await ng('add', `@angular/material${tag}`, '--skip-confirmation');
1512

tests/legacy-cli/e2e/tests/commands/add/add-material.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ import { ng } from '../../../utils/process';
55
import { isPrereleaseCli } from '../../../utils/project';
66

77
export default async function () {
8-
// TODO(crisbeto): temporarily disabled until Material is updated
9-
return;
10-
118
// forcibly remove in case another test doesn't clean itself up
129
await rimraf('node_modules/@angular/material');
1310

tests/legacy-cli/e2e/tests/misc/invalid-schematic-dependencies.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ import { installPackage, uninstallPackage } from '../../utils/packages';
44
import { isPrereleaseCli } from '../../utils/project';
55

66
export default async function () {
7-
// TODO(crisbeto): temporarily disabled until Material is updated
8-
return;
9-
107
// Must publish old version to local registry to allow install. This is especially important
118
// for release commits as npm will try to request tooling packages that are not on the npm registry yet
129
await publishOutdated('@schematics/angular@7');

0 commit comments

Comments
 (0)
0