8000 feat(service-worker): support notification closes by arturovt · Pull Request #61442 · angular/angular · GitHub
[go: up one dir, main page]

Skip to content

feat(service-worker): support notification closes #61442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you acc 8000 ount related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arturovt
Copy link
Contributor
@arturovt arturovt commented May 16, 2025

In this commit, support for notificationclose events has been added to the service worker Driver.

When a notification is closed (either by user dismissal or programmatically), the Driver now captures the event, extracts the relevant notification options, and broadcasts a NOTIFICATION_CLOSE message to clients. This ensures the application is aware of notification lifecycle events and can react accordingly.

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: service-worker Issues related to the @angular/service-worker package labels May 16, 2025
@ngbot ngbot bot added this to the Backlog milestone May 16, 2025
@arturovt arturovt force-pushed the feat/service-worker-notificationClose branch 2 times, most recently from 76c0172 to 4224ee1 Compare May 16, 2025 22:09
@arturovt
Copy link
Contributor Author

@atscott when you have time, can you review this change? (pinging you because you reviewed service-worker PRs before)

In this commit, support for `notificationclose` events has been added to the service worker Driver.

When a notification is closed (either by user dismissal or programmatically), the Driver now captures the event, extracts the relevant notification options, and broadcasts a `NOTIFICATION_CLOSE` message to clients. This ensures the application is aware of notification lifecycle events and can react accordingly.
@arturovt arturovt force-pushed the feat/service-worker-notificationClose branch from 4224ee1 to 03427c6 Compare May 17, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: service-worker Issues related to the @angular/service-worker package detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0