8000 refactor(zone.js): drop passive supported check by arturovt · Pull Request #58010 · angular/angular · GitHub
[go: up one dir, main page]

Skip to content

refactor(zone.js): drop passive supported check #58010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

arturovt
Copy link
Contributor
@arturovt arturovt commented Sep 29, 2024

https://caniuse.com/passive-event-listener
Passive event listeners are supported in all major evergreen browsers. Thus, we don't need to check whether passives are supported.

@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Sep 29, 2024
@JeanMeche JeanMeche marked this pull request as ready for review September 29, 2024 22:53
@pullapprove pullapprove bot requested a review from JiaLiPassion September 29, 2024 22:53
@JeanMeche JeanMeche marked this pull request as draft September 29, 2024 22:56
@JeanMeche
Copy link
Member

Fwiw, Domino doesn't support passive events.

@arturovt
Copy link
Contributor Author
arturovt commented Sep 30, 2024

@JeanMeche the EventTarget is not patched in Node.js (only the event emitter, but it doesn’t care about options).

upd: I suspect this might go after your's is merged: #55745

@eneajaho
Copy link
Contributor

This should drop some bytes from every angular app 😁

@arturovt arturovt marked this pull request as ready for review September 30, 2024 13:12
@arturovt arturovt force-pushed the refactor/zone-passive branch from facb4a8 to 445a628 Compare September 30, 2024 13:27
@pkozlowski-opensource pkozlowski-opensource added the area: zones Issues related to zone.js label Oct 23, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 23, 2024
@thePunderWoman thePunderWoman added the action: global presubmit The PR is in need of a google3 global presubmit label Apr 30, 2025
@arturovt arturovt force-pushed the refactor/zone-passive branch from 445a628 to 7e0355f Compare April 30, 2025 17:02
@thePunderWoman
Copy link
Contributor

TGP

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: global presubmit The PR is in need of a google3 global presubmit labels May 1, 2025
Copy link
Contributor
@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added the target: rc This PR is targeted for the next release-candidate label May 1, 2025
@thePunderWoman
Copy link
Contributor

Caretaker note: TGP is green and we can merge with the current set of approvals.

@AndrewKushnir
Copy link
Contributor

Since this PR contains a breaking change note in a commit and we are in a feature freeze state (no breaking changes as well), the merge tooling doesn't allow me to merge it. We could either wait for v21 or remove the breaking changes note (we don't support IE anyways). @thePunderWoman what do you think?

@thePunderWoman
Copy link
Contributor

My take is that this isn't really a breaking change since we already don't support IE. I think it's safe to remove the breaking change note and label and merge it.

https://caniuse.com/passive-event-listener
Passive event listeners are supported in all major evergreen browsers.
Thus, we don't need to check whether passives are supported.
@AndrewKushnir AndrewKushnir force-pushed the refactor/zone-passive branch from 7e0355f to 7975c4c Compare May 1, 2025 18:26
@angular-robot angular-robot bot removed the detected: breaking change PR contains a commit with a breaking change label May 1, 2025
@AndrewKushnir
Copy link
Contributor
AndrewKushnir commented May 1, 2025

My take is that this isn't really a breaking change since we already don't support IE. I think it's safe to remove the breaking change note and label and merge it.

@thePunderWoman thanks for the reply. I've updated the commit message to drop the "breaking change" part and will proceed with the merge.

@AndrewKushnir AndrewKushnir removed the request for review from JiaLiPassion May 1, 2025 18:41
@pullapprove pullapprove bot requested a review from JiaLiPassion May 1, 2025 18:41
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 5f31c95.

The changes were merged into the following branches: main, 20.0.x

AndrewKushnir pushed a commit that referenced this pull request May 1, 2025
https://caniuse.com/passive-event-listener
Passive event listeners are supported in all major evergreen browsers.
Thus, we don't need to check whether passives are supported.

PR Close #58010
@arturovt arturovt deleted the refactor/zone-passive branch May 1, 2025 20:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0