-
Notifications
You must be signed in to change notification settings - Fork 26.4k
refactor(zone.js): drop passive supported check #58010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fwiw, Domino doesn't support passive events. |
@JeanMeche the EventTarget is not patched in Node.js (only the event emitter, but it doesn’t care about options). upd: I suspect this might go after your's is merged: #55745 |
This should drop some bytes from every angular app 😁 |
facb4a8
to
445a628
Compare
445a628
to
7e0355f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Caretaker note: TGP is green and we can merge with the current set of approvals. |
Since this PR contains a breaking change note in a commit and we are in a feature freeze state (no breaking changes as well), the merge tooling doesn't allow me to merge it. We could either wait for v21 or remove the breaking changes note (we don't support IE anyways). @thePunderWoman what do you think? |
My take is that this isn't really a breaking change since we already don't support IE. I think it's safe to remove the breaking change note and label and merge it. |
https://caniuse.com/passive-event-listener Passive event listeners are supported in all major evergreen browsers. Thus, we don't need to check whether passives are supported.
7e0355f
to
7975c4c
Compare
@thePunderWoman thanks for the reply. I've updated the commit message to drop the "breaking change" part and will proceed with the merge. |
This PR was merged into the repository by commit 5f31c95. The changes were merged into the following branches: main, 20.0.x |
https://caniuse.com/passive-event-listener Passive event listeners are supported in all major evergreen browsers. Thus, we don't need to check whether passives are supported. PR Close #58010
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
https://caniuse.com/passive-event-listener
Passive event listeners are supported in all major evergreen browsers. Thus, we don't need to check whether passives are supported.