Type RedirectFunction use with Route config property redirecTo asynchornous #61047
Comments
|
This should be a canActivate guard. Such redirect is probably the n°1 use case of that guard. |
Ok great, thanks @JeanMeche for the feedback. I would add that there is one "kind of annoying" thing and this is for a route with only a path and a guard you have to specify either a dummy component or a empty children array. Any plan on making this config without those required fields? export const routes = [
// ...
{
path: '**',
canActivate: [redirectCanActivateFn],
children: []
}
] |
|
Actually the feature will land in v20, see #60863. |
|
Right, this’ll be available in v20 but I’ll also add that I don’t really see where it’s useful. You already need to have your login guard on the home page so why not just have ** unconditionally redirect to the home route? |
@atscott with this particulary case you are absolutly right. But my real use case is a bit more complicated since the redirection depends on user's permissions to targets the first allowed page. Maybe I'm wrong but when a developper have to do something (fix/new feature) and have to touch the routes logic, it's more obvious and clear what will happen if the router fallback on '**'. Instead of navigating to another route config and guard, and undertstand the step the router takes, he or she will have the anwser right in the redirectTo function. What do you think? |
|
@dquirion Potentially. In the case of the example given here, I don't think duplicating the redirect logic in |
|
I need the async redirect in a feature I'm working on right now. The route setup is roughly the following: // main.routes.ts
...
{
path: 'reports',
loadChildren: () => import('...'),
canActivate: [LoginGuard],
},
...
// reports.routes.ts
export const routes: Routes = [
{
path: '',
component: Reports,
canActivate: [PermissionGuard(['permission-a', 'permission-b'])],
children: [
{
path: '',
pathMatch: 'full',
redirectTo: 'report-a',
},
{
path: 'report-a',
canActivate: [PermissionGuard(['permission-a'])],
loadComponent: () => import('...'),
},
{
path: 'report-b',
canActivate: [PermissionGuard(['permission-a'])],
loadComponent: () => import('...'),
},
],
},
];Let's say As an important note, the |
Which @angular/* package(s) are relevant/related to the feature request?
router
Description
Hi, i just came across the new
RedirectFunctiontype used in route config propertyredirectToand I was hoping that it supports asynchronous function just as the the canActivateFn/canMatchFn do.Proposed solution
Support promise or observables just a the guard functions.
Alternatives considered
Right now i use a
canActivateFnguard to achieved the same behavior. But as the doc suggests, I found theRedirectFunctionclearer and more logical for such case.The text was updated successfully, but these errors were encountered: