8000 `forbidOrphanComponents` hangs a brand new CLI application · Issue #52286 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

forbidOrphanComponents hangs a brand new CLI application #52286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000 Closed
cexbrayat opened this issue Oct 19, 2023 · 2 comments
Closed

forbidOrphanComponents hangs a brand new CLI application #52286

cexbrayat opened this issue Oct 19, 2023 · 2 comments
Assignees
@pmvald
Labels
area: compiler Issues related to `ngc`, Angular's template compiler
Milestone
needsTriage

Comments

@cexbrayat
Copy link
Member

Which @angular/* package(s) are the source of the bug?

compiler-cli

Is this a regression?

No

Description

Adding "forbidOrphanComponents": true, to a brand new CLI application (17.0.0-rc.0) hangs ng serve

npx @angular/cli@next new orphan-components --defaults --no-routing --skip-tests
cd orphan-components
# add forbidOrphanComponents to tsconfig.json
ng serve

ng serve is stuck on Building.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 17.0.0-rc.0
Node: 18.16.0
Package Manager: npm 9.7.1
OS: darwin arm64

Angular: 17.0.0-rc.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.0-rc.0
@angular-devkit/build-angular   17.0.0-rc.0
@angular-devkit/core            17.0.0-rc.0
@angular-devkit/schematics      17.0.0-rc.0
@schematics/angular             17.0.0-rc.0
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.0

Anything else?

No response
@JeanMeche
Copy link
Member

FWIW, aot: false is required for this feature.

But an error would be better than the current behaviour 😊

@pmvald
Copy link
Member
pmvald commented Oct 19, 2023

This feature is being used experimentally in Google at the moment. never tried that for 3P using ng cli. But I'll take a look and see why this happens. A quick thinking is it could be due to sanity checks that we do and exceptions we throw ...

@AndrewKushnir AndrewKushnir added the area: compiler Issues related to `ngc`, Angular's template compiler label Oct 19, 2023
@ngbot ngbot bot added this to the needsTriage milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmvald pmvald

Labels
area: compiler Issues related to `ngc`, Angular's template compiler
Projects
None yet
Milestone
needsTriage
Development

No branches or pull requests
4 participants
@cexbrayat @JeanMeche @pmvald @AndrewKushnir
0