10000 refactor(compiler-cli): move typeCheckHostBindings option (#60267) · angular/angular@bf2b025 · GitHub
[go: up one dir, main page]
Skip to content

Commit bf2b025

Browse files
crisbetopkozlowski-opensource
crisbeto
authored and
pkozlowski-opensource
committed
refactor(compiler-cli): move typeCheckHostBindings option (#60267)
Moves the `typeCheckHostBindings` option into `StrictTemplateOptions` and renames the latter. PR Close #60267
1 parent 1971e57 commit bf2b025

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

‎goldens/public-api/compiler-cli/compiler_options.api.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,15 @@ export interface MiscOptions {
6060
compileNonExportedClasses?: boolean;
6161
disableTypeScriptVersionCheck?: boolean;
6262
forbidOrphanComponents?: boolean;
63-
typeCheckHostBindings?: boolean;
6463
}
6564

6665
// @public
67-
export interface StrictTemplateOptions {
66+
export interface TargetOptions {
67+
compilationMode?: 'full' | 'partial' | 'experimental-local';
68+
}
69+
70+
// @public
71+
export interface TypeCheckingOptions {
6872
strictAttributeTypes?: boolean;
6973
strictContextGenerics?: boolean;
7074
strictDomEventTypes?: boolean;
@@ -76,11 +80,7 @@ export interface StrictTemplateOptions {
7680
strictOutputEventTypes?: boolean;
 8000
7781
strictSafeNavigationTypes?: boolean;
7882
strictTemplates?: boolean;
79-
}
80-
81-
// @public
82-
export interface TargetOptions {
83-
compilationMode?: 'full' | 'partial' | 'experimental-local';
83+
typeCheckHostBindings?: boolean;
8484
}
8585

8686
// (No @packageDocumentation comment for this package)

‎packages/compiler-cli/src/ngtsc/core/api/src/options.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
I18nOptions,
1515
LegacyNgcOptions,
1616
MiscOptions,
17-
StrictTemplateOptions,
17+
TypeCheckingOptions,
1818
TargetOptions 8000 ,
1919
} from './public_options';
2020

@@ -148,7 +148,7 @@ export interface NgCompilerOptions
148148
LegacyNgcOptions,
149149
BazelAndG3Options,
150150
DiagnosticOptions,
151-
StrictTemplateOptions,
151+
TypeCheckingOptions,
152152
TestOnlyOptions,
153153
I18nOptions,
154154
TargetOptions,

‎packages/compiler-cli/src/ngtsc/core/api/src/public_options.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,14 @@ export interface LegacyNgcOptions {
8989
}
9090

9191
/**
92-
* Options related to template type-checking and its strictness.
92+
* Options related to Angular-specific type-checking and its strictness.
9393
*
9494
* @publicApi
9595
*/
96-
export interface StrictTemplateOptions {
96+
export interface TypeCheckingOptions {
97+
/** Whether type checking of host bindings is enabled. */
98+
typeCheckHostBindings?: boolean;
99+
97100
/**
98101
* If `true`, implies all template strictness flags below (unless individually disabled).
99102
*
@@ -430,9 +433,6 @@ export interface TargetOptions {
430433
* @publicApi
431434
*/
432435
export interface MiscOptions {
433-
/** Whether type checking of host bindings is enabled. */
434-
typeCheckHostBindings?: boolean;
435-
436436
/**
437437
* Whether the compiler should avoid generating code for classes that haven't been exported.
438438
* Defaults to `true`.

‎packages/language-service/testing/src/project.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import {
1010
InternalOptions,
1111
LegacyNgcOptions,
12-
StrictTemplateOptions,
12+
TypeCheckingOptions,
1313
} from '@angular/compiler-cli/src/ngtsc/core/api';
1414
import {
1515
absoluteFrom,
@@ -63,7 +63,7 @@ function writeTsconfig(
6363
);
6464
}
6565

66-
export type TestableOptions = StrictTemplateOptions &
66+
export type TestableOptions = TypeCheckingOptions &
6767
InternalOptions &
6868
Pick<LegacyNgcOptions, 'fullTemplateTypeCheck'>;
6969

0 commit comments

Comments
 (0)
0