8000 build: do not run ssr-benchmarks when using `//...` (#61566) · angular/angular@909e543 · GitHub
[go: up one dir, main page]

Skip to content

Commit 909e543

Browse files
devversionkirjs
authored andcommitted
build: do not run ssr-benchmarks when using //... (#61566)
These are also excluded on CI, and shouldn't run locally either as they are "manual debug" targets. PR Close #61566
1 parent 9d7768c commit 909e543

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

modules/ssr-benchmarks/BUILD.bazel

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ ng_integration_test(
77
"yarn ng build",
88
"node ./dist/ssr-benchmarks/server/server.mjs",
99
],
10+
tags = ["manual"],
1011
)
1112

1213
## This target is intended to run the benchmark in a browser
@@ -17,27 +18,24 @@ ng_integration_test(
1718
commands = [
1819
"yarn install --cache-folder ./.yarn_local_cache",
1920

20-
# The patch only applies for the browser target (to remove the DOM Emulation polyfills and browser incompatible code)
21-
"yarn patch",
2221
#
2322
"NG_BUILD_MANGLE=0 yarn ng build --configuration production,browser",
2423
"yarn http-server ./dist",
2524
],
25+
tags = ["manual"],
2626
)
2727

2828
# This target is mostly intended for investigating via the devTools using the flamechart
2929
ng_integration_test(
3030
name = "run_browser_emulated_dom",
3131
commands = [
3232
"yarn install --cache-folder ./.yarn_local_cache",
33-
# We keep the emulated dom in this target
34-
# But still need to drop the node import which doesn't work in browsers.
35-
"git apply patches/@angular-devkit+build-angular++@angular+build+19.0.0-next.6+require.patch",
3633

3734
# We keep the symbols with the NG_BUILD_MANGLE flag
3835
"NG_BUILD_MANGLE=0 yarn ng build",
3936
"yarn http-server ./dist",
4037
],
38+
tags = ["manual"],
4139
)
4240

4341
# This is a target to investigate with deopt explorer (https://github.com/microsoft/deoptexplorer-vscode)
@@ -58,4 +56,5 @@ ng_integration_test(
5856
--detailed-line-info \
5957
./dist/ssr-benchmarks/server/server.mjs narrowRun",
6058
],
59+
tags = ["manual"],
6160
)

modules/ssr-benchmarks/package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,12 @@
22
"name": "ssr-benchmark",
33
"version": "0.0.0",
44
"scripts": {
5-
"patch": "yarn patch-package",
65
"ng": "ng",
76
"http-server": "http-server"
87
},
98
"license": "MIT",
109
"dependencies": {
11-
"@angular-devkit/build-angular": "file:../../node_modules/@angular-devkit/build-angular",
10+
"@angular-devkit/build-angular": "20.0.0-rc.1",
1211
"@angular/cli": "file:../../node_modules/@angular/cli",
1312
"@angular/common": "file:../../dist/packages-dist/common",
1413
"@angular/compiler": "file:../../dist/packages-dist/compiler",
@@ -20,7 +19,6 @@
2019
"@angular/ssr": "file:../../node_modules/@angular/ssr",
2120
"rxjs": "file:../../node_modules/rxjs",
2221
"typescript": "file:../../node_modules/typescript",
23-
"http-server": "file:../../node_modules/http-server",
24-
"patch-package": "file:../../node_modules/patch-package"
22+
"http-server": "file:../../node_modules/http-server"
2523
}
2624
}

0 commit comments

Comments
 (0)
0