fixup! perf(core): do not recurse into modules that have already been registered

JoostK · JoostK · commit 2b052351ec42 · 2020-10-31T00:08:24.000+01:00
diff --git a/packages/core/src/linker/ng_module_factory_registration.ts b/packages/core/src/linker/ng_module_factory_registration.ts
@@ -44,7 +44,9 @@ export function registerNgModuleType(ngModuleType: NgModuleType): void {
   const visited = new Set<NgModuleType>();
   recurse(ngModuleType);
   function recurse(ngModuleType: NgModuleType): void {
-    const def = getNgModuleDef(ngModuleType, true);
+    // The imports array of an NgModule must refer to other NgModules,
+    // so an error is thrown if no module definition is available.
+    const def = getNgModuleDef(ngModuleType, /* throwNotFound */ true);
     const id = def.id;
     if (id !== null) {
       const existing = modules.get(id) as NgModuleType | null;
