8000 refactor(upgrade): remove unused parameters/properties/variables (#39… · angular/angular@166c783 · GitHub
[go: up one dir, main page]
Skip to content

Commit 166c783

Browse files
gkalpakmhevery
gkalpak
authored and
mhevery
committed
refactor(upgrade): remove unused parameters/properties/variables (#39965)
This commit removes some unused parameters, properties and variables in various `@angular/upgrade` functions. PR Close #39965
1 parent 0969527 commit 166c783

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

‎packages/upgrade/src/common/src/downgrade_component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,8 @@ export function downgradeComponent(info: {
174174

175175
const injectorPromise = new ParentInjectorPromise(element);
176176
const facade = new DowngradeComponentAdapter(
177-
element, attrs, scope, ngModel, injector, $injector, $compile, $parse,
178-
componentFactory, wrapCallback);
177+
element, attrs, scope, ngModel, injector, $compile, $parse, componentFactory,
178+
wrapCallback);
179179

180180
const projectableNodes = facade.compileContents();
181181
facade.createComponent(projectableNodes);

‎packages/upgrade/src/common/src/downgrade_component_adapter.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import {ApplicationRef, ChangeDetectorRef, ComponentFactory, ComponentRef, EventEmitter, Injector, OnChanges, SimpleChange, SimpleChanges, StaticProvider, Testability, TestabilityRegistry, Type} from '@angular/core';
1010

11-
import {IAttributes, IAugmentedJQuery, ICompileService, IInjectorService, INgModelController, IParseService, IScope} from './angular1';
11+
import {IAttributes, IAugmentedJQuery, ICompileService, INgModelController, IParseService, IScope} from './angular1';
1212
import {PropertyBinding} from './component_info';
1313
import {$SCOPE} from './constants';
1414
import {getTypeName, hookupNgModel, strictEquals} from './util';
@@ -33,8 +33,8 @@ export class DowngradeComponentAdapter {
3333
constructor(
3434
private element: IAugmentedJQuery, private attrs: IAttributes, private scope: IScope,
3535
private ngModel: INgModelController, private parentInjector: Injector,
36-
private $injector: IInjectorService, private $compile: ICompileService,
37-
private $parse: IParseService, private componentFactory: ComponentFactory<any>,
36+
private $compile: ICompileService, private $parse: IParseService,
37+
private componentFactory: ComponentFactory<any>,
3838
private wrapCallback: <T>(cb: () => T) => () => T) {
3939
this.componentScope = scope.$new();
4040
}
@@ -250,7 +250,6 @@ export class DowngradeComponentAdapter {
250250
*/
251251
export function groupNodesBySelector(ngContentSelectors: string[], nodes: Node[]): Node[][] {
252252
const projectableNodes: Node[][] = [];
253-
let wildcardNgContentIndex: number;
254253

255254
for (let i = 0, ii = ngContentSelectors.length; i < ii; ++i) {
256255
projectableNodes[i] = [];

‎packages/upgrade/src/common/src/upgrade_helper.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ export class UpgradeHelper {
4141
private readonly $controller: IControllerService;
4242

4343
constructor(
44-
private injector: Injector, private name: string, elementRef: ElementRef,
45-
directive?: IDirective) {
44+
injector: Injector, private name: string, elementRef: ElementRef, directive?: IDirective) {
4645
this.$injector = injector.get($INJECTOR);
4746
this.$compile = this.$injector.get($COMPILE);
4847
this.$controller = this.$injector.get($CONTROLLER);

‎packages/upgrade/src/common/test/downgrade_component_adapter_spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ withEachNg1Version(() => {
131131
let scope: angular.IScope; // mock
132132
let ngModel = undefined as any;
133133
let parentInjector: Injector; // testbed
134-
let $injector = undefined as any;
135134
let $compile = undefined as any;
136135
let $parse = undefined as any;
137136
let componentFactory: ComponentFactory<any>; / 7DBC / testbed
@@ -166,8 +165,8 @@ withEachNg1Version(() => {
166165
parentInjector = TestBed;
167166

168167
return new DowngradeComponentAdapter(
169-
element, attrs, scope, ngModel, parentInjector, $injector, $compile, $parse,
170-
componentFactory, wrapCallback);
168+
element, attrs, scope, ngModel, parentInjector, $compile, $parse, componentFactory,
169+
wrapCallback);
171170
}
172171

173172
beforeEach(() => {

0 commit comments

Comments
 (0)
0