Backport request orientation cache

pyricau · pyricau · commit cd1add5f6260 · 2025-02-26T12:32:17.000-08:00
API 35 / Android 15 added a field cache to `Activity.setRequestedOrientation()` because every call would lead to an IPC call, which can be expensive and hammer the system. This change backports the API 35 behavior. https://cs.android.com/android/_/android/platform/frameworks/base/+/14b59e53b82dbeb93ca1c8ac612c13d62c8672e9
diff --git a/core/core/src/main/java/androidx/core/app/ComponentActivity.kt b/core/core/src/main/java/androidx/core/app/ComponentActivity.kt
@@ -50,6 +50,8 @@ public open class ComponentActivity : Activity(), LifecycleOwner, KeyEventDispat
      */
     @Suppress("LeakingThis") private val lifecycleRegistry = LifecycleRegistry(this)
 
+    private var lastRequestedOrientation: Int = ActivityInfo.SCREEN_ORIENTATION_UNSET
+
     /**
      * Store an instance of [ExtraData] for later retrieval by class name via [getExtraData].
      *
@@ -110,6 +112,18 @@ public open class ComponentActivity : Activity(), LifecycleOwner, KeyEventDispat
         } else KeyEventDispatcher.dispatchKeyEvent(this, decor, this, event)
     }
 
+    override fun setRequestedOrientation(orientation: Int) {
+        // Sets this Activity's orientation, only if the orientation value has changed or if a
+        // value hasn't been previously set. This avoids unnecessary Binder calls, which
+        // can be expensive. This caching was added to Activity.java in API level 35.
+        if (Build.VERSION.SDK_INT >= 35) {
+            super.setRequestedOrientation(orientation)
+        } else if (orientation != lastRequestedOrientation) {
+            lastRequestedOrientation = orientation
+            super.setRequestedOrientation(orientation)
+        }
+    }
+
     /**
      * Checks if the internal state should be dump, as some special args are handled by [Activity]
      * itself.
