Use canonical names #453
Use canonical names #453
Conversation
|
Hi @naixx, That's a really good idea :) I see 5 commits in this PR, only one is related to your changes. Could you make a new PR that only include your changes in order to simplify the review ? :) |
|
@mathieuboniface can you give an advice, how to do it? Overall changes concern only PR. While merging this PR can we make it as one commit? |
# Add the excilys repo to your remotes
git remote add excilys https://github.com/excilys/androidannotations.git
git fetch excilys
# Checkout the last revision on excilys/develop as a new branch
git checkout -b use_canonical_names2 excilys/develop
# Pick the change in the new branch
git cherry-pick b1cd2e814b7b455e35c926a0ab1c5dc7583fe46c
# Push to your repo in order to make new PR
git push origin use_canonical_names2I'm not sure it is the best way to do, but it should work :) |
|
Thank you @mathieuboniface! As I understood, this script transfers one commit to another clean branch. But there may be a problem, that my develop branch has all these garbage merge commits, and I branched from it for 434. So, is there any way to combine|squash commits in my develop? Can it be cleaned some way? |
|
Challenge finished via! Now, trying to fix my develop :) |
|
This pull request should be linked to a milestone. I did a $ git branch --contains de1874b
* developSo it appears this commit is only on |
This is a small pull request to eliminate hardcoded type names. Probably, some other names should be replaced or added.