Generate api helper classes at compile time #410
Conversation
** This change make the future release non backward compatible **
There was a problem hiding this comment.
How is that related to your changes? Moving Scope means breaking package retro compatibility.. of course we already broke it by changing to org.androidannotations, but I'd like a clear explanation on this change.
There was a problem hiding this comment.
I've made this change to enhance consistency.
We have already an enum named Scope to deal with @SharedPreference declared as an inner class of this annotation. This Scope class related to @ebean was declared into the api package (org.androidannotations.api.Scope) like the helper classes and the @ebean annotation in the annotation package (org.androidannotations.annotations).
There was a problem hiding this comment.
Ok. Then we should update the release notes of 3.0 to write this as one of the non backward compatible changes.
|
Very nice on the overall, that's an in depth change that's well handled. A few more notes:
|
There was a problem hiding this comment.
Different options, worth looking at: http://stackoverflow.com/questions/1921975/java-convert-package-name-to-path
|
This PR is ready to be reviewed. |
Generate api helper classes at compile time. Fixes #129
See #129