8000 Method based @ViewsById isEmpty() · Issue #1966 · androidannotations/androidannotations · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Method based @ViewsById isEmpty() #1966

@miszmaniac

Description

@miszmaniac

I've tried to used method based @ViewsById method, but found out that method parameter is empty List.
This happens beacuse of wrong order of calls in generated code.
I've also noticed that test of this part of code is incorrect.
zrzut ekranu 2017-03-07 11 32 31

AndroidAnnotations version:
4.2.0
Android compile SDK version:
25
Annotated code:

 @ViewsById({R.id.divider_1, R.id.divider_2, R.id.divider_3, R.id.short_cut_container})
    void init(List<View> views) {
       ...
    }

Expected generated code:

@Override
    public void onViewChanged(HasViews hasViews) {
        ArrayList<View> list_init_views = new ArrayList<View>();
        View view_divider_1 = hasViews.findViewById(R.id.divider_1);
        View view_divider_2 = hasViews.findViewById(R.id.divider_2);
        View view_divider_3 = hasViews.findViewById(R.id.divider_3);
        View view_short_cut_container = hasViews.findViewById(R.id.short_cut_container);

        if (view_divider_1 != null) {
            list_init_views.add(view_divider_1);
        }
        if (view_divider_2 != null) {
            list_init_views.add(view_divider_2);
        }
        if (view_divider_3 != null) {
            list_init_views.add(view_divider_3);
        }
        if (view_short_cut_container!= null) {
            list_init_views.add(view_short_cut_container);
        }
    {
            List<View> views = null;
            views = list_init_views;
            init(views);
        }
    }

Actual generated code:

@Override
    public void onViewChanged(HasViews hasViews) {
        ArrayList<View> list_init_views = new ArrayList<View>();
        View view_divider_1 = hasViews.findViewById(R.id.divider_1);
        View view_divider_2 = hasViews.findViewById(R.id.divider_2);
        View view_divider_3 = hasViews.findViewById(R.id.divider_3);
        View view_short_cut_container = hasViews.findViewById(R.id.short_cut_container);

        {
            List<View> vie
5DCB
ws = null;
            views = list_init_views;
            init(views);
        }
        if (view_divider_1 != null) {
            list_init_views.add(view_divider_1);
        }
        if (view_divider_2 != null) {
            list_init_views.add(view_divider_2);
        }
        if (view_divider_3 != null) {
            list_init_views.add(view_divider_3);
        }
        if (view_short_cut_container!= null) {
            list_init_views.add(view_short_cut_container);
        }
    }

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0